Skip to content

fix(android): bridgeless mode broken on react-native 0.74#1068

Merged
tido64 merged 1 commit into
react-native-async-storage:mainfrom
Kudo:@kudo/fix-rn074-bridgeless
Feb 28, 2024
Merged

fix(android): bridgeless mode broken on react-native 0.74#1068
tido64 merged 1 commit into
react-native-async-storage:mainfrom
Kudo:@kudo/fix-rn074-bridgeless

Conversation

@Kudo

@Kudo Kudo commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

Summary

This PR tries to fix the [@RNC/AsyncStorage]: NativeModule: AsyncStorage is null error when running on react-native@0.74.0-rc.1. The regression was coming from react/react-native#41412 and react/react-native#43213 has more discussion. This PR follows the create-react-native-library template to rely on BuildConfig

Test Plan

$ npx @react-native-community/cli@latest init RN074 --version next
$ cd RN074
$ yarn add @react-native-async-storage/async-storage
# edit App.tsx for using async-storage
$ cd android
$ ./gradlew -PnewArchEnabled=true :app:installDebug
$ ./gradlew -PnewArchEnabled=true -PAsyncStorage_useNextStorage=true :app:installDebug

@Kudo Kudo requested review from krizzu and tido64 as code owners February 28, 2024 08:09

@tido64 tido64 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kudo ❤️

@tido64 tido64 merged commit 253126d into react-native-async-storage:main Feb 28, 2024
@AsyncStorageBot

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.22.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@krizzu

krizzu commented Feb 28, 2024

Copy link
Copy Markdown
Member

Thanks @Kudo 🙏

@Kudo Kudo deleted the @kudo/fix-rn074-bridgeless branch February 28, 2024 12:32
@Kudo

Kudo commented Feb 28, 2024

Copy link
Copy Markdown
Contributor Author

thank you folks for merging and releasing the fix quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants