Crawl reports 'no libraries meet eligibility threshold' incorrectly on admin/data/libraries

[react-foundation-bot]

Filed by @sethwebster via React Foundation Store

When performing a crawl on the admin/data/libraries page, the system completes the crawl but incorrectly reports that no libraries meet the eligibility threshold, despite libraries existing that should qualify.

Steps to reproduce

1. Go to admin/data/libraries
2. Initiate a crawl
3. Allow the crawl to complete
4. Observe the message indicating no libraries meet eligibility threshold

Expected
Libraries that meet the eligibility threshold should be listed or acknowledged after the crawl finishes.

Actual
The crawl finishes but displays a message that no libraries meet the eligibility threshold, which is incorrect.

Severity: medium

---

cc @claude - This issue was created by the chatbot based on user feedback.

Chatbot metadata:

• url: http://localhost:3000/admin/data/libraries
• userAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/26.0.1 Safari/605.1.15
• conversationId: 9c6b46c074eb76eafae2fbea1790ff83
• created_at: 2025-10-28T20:54:28.520Z

[claude]

Claude finished @react-foundation-bot's task —— View job • claude/issue-35-20251028-2054 • Create PR ➔

---

Fixed library eligibility threshold bug

I've identified and fixed the issue where the admin page incorrectly displayed "no libraries meet eligibility threshold" after a successful crawl.

Root Cause

The generateQuarterlyAllocation method includes all libraries in the returned array (both eligible and ineligible). Libraries below the 15% RIS threshold receive allocation_usd: 0, but they're still included in the array. The frontend was checking allocation.libraries.length === 0 to determine if any libraries met the threshold, which would never be true since the array always contains all libraries.

Fix Applied

Updated src/app/admin/data/libraries/page.tsx:155-209 to:

• Filter for only eligible libraries (those with allocation_usd > 0)
• Show the warning only when no eligible libraries exist
• Display correct count for "Libraries Scored" (only eligible libraries)
• Calculate average allocation correctly (only among eligible libraries)
• Show correct top library (first eligible library, not first in sorted array)

Changes Made

The fix optimizes performance by filtering once and reusing the result:

const eligibleLibraries = data.allocation.libraries.filter(lib => lib.allocation_usd > 0);
const topLibrary = eligibleLibraries[0]; // Already sorted by RIS descending

Then uses eligibleLibraries.length and topLibrary throughout instead of checking allocation.libraries.length.

Testing Note

Since I don't have access to run npm install, npx tsc --noEmit, or npm run lint, please verify:

1. TypeScript compiles without errors
2. Lint passes
3. The page correctly shows eligible library counts after a crawl

--- • Branch: claude/issue-35-20251028-2054

[sethwebster]

Fixed previously