RangeProps allows number for pushable#725
Open
RobertMurrayImprobable wants to merge 1 commit intoreact-component:masterfrom
Open
RangeProps allows number for pushable#725RobertMurrayImprobable wants to merge 1 commit intoreact-component:masterfrom
pushable#725RobertMurrayImprobable wants to merge 1 commit intoreact-component:masterfrom
Conversation
The top-level `README` describes the `pushable` prop of `Range` as `boolean` or `number` (or `undefined`), but the type annotation in `Range.tsx` is `pushable?: boolean;`. When developing with `rc-slider` in Typescript, using for example `pushable={5}` causes a type error, and the only way around this is `pushable={(5 as unknown) as undefined}` which then produces the expected behaviour. This type annotation appears to be incorrect and would be great to have it updated.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/slider/4a591k7r7 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #725 +/- ##
=======================================
Coverage 88.49% 88.49%
=======================================
Files 11 11
Lines 756 756
Branches 199 199
=======================================
Hits 669 669
Misses 87 87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Rebase please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top-level
READMEdescribes thepushableprop ofRangeasbooleanornumber(orundefined), but the type annotation inRange.tsxispushable?: boolean;. When developing withrc-sliderin Typescript, using for examplepushable={5}causes a type error, and the only way around this ispushable={(5 as unknown) as undefined}which then produces the expected behaviour. This type annotation appears to be incorrect and would be great to have it updated.