Skip to content

fix(frontier): revert removal of some deprecated fields#468

Merged
rohilsurana merged 2 commits intomainfrom
fix/frontier-revert-deprecated-fields
Apr 7, 2026
Merged

fix(frontier): revert removal of some deprecated fields#468
rohilsurana merged 2 commits intomainfrom
fix/frontier-revert-deprecated-fields

Conversation

@rohilsurana
Copy link
Copy Markdown
Member

Summary

  • Revert removal of deprecated fields that are still in use:
    • ChangeSubscriptionRequest.plan (field 4) and ChangeSubscriptionRequest.immediate (field 5)
    • ListBillingTransactionsRequest.since (field 3)

Test plan

  • Verify proto compiles successfully
  • Verify dependent services still work with these fields

…ionRequest and ListBillingTransactionsRequest
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

Warning

Rate limit exceeded

@rohilsurana has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 12 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 23 minutes and 12 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1b2dccc9-b1b8-44a8-9fca-59e6126e6186

📥 Commits

Reviewing files that changed from the base of the PR and between 611f764 and cfb034a.

📒 Files selected for processing (1)
  • raystack/frontier/v1beta1/frontier.proto
📝 Walkthrough

Walkthrough

Protocol Buffer schema changes to two message types in the frontier service. ListBillingTransactionsRequest added a deprecated since field with type google.protobuf.Timestamp at field number 3, and reduced reserved field numbers. ChangeSubscriptionRequest added two deprecated fields: plan (string) at field 4 and immediate (bool) at field 5, while reducing its reserved field set. These changes maintain backward compatibility through field deprecation marking.

Suggested reviewers

  • whoAbhishekSah
  • rsbh
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: reverting removal of deprecated fields in the frontier proto.
Description check ✅ Passed The description is clearly related to the changeset, listing the specific deprecated fields being reverted and providing a test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedApr 7, 2026, 5:43 AM

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
raystack/frontier/v1beta1/frontier.proto (1)

545-549: Reverted since field looks correct; consider adding a deprecation comment.

The revert correctly restores field 3 with the [deprecated = true] annotation. For consistency with the ChangeSubscriptionRequest changes (which include comments explaining the deprecation), consider adding a brief comment indicating that start_range/end_range should be used instead.

💡 Optional: Add deprecation comment
  reserved 2;

+ // deprecated in favor of start_range/end_range
  google.protobuf.Timestamp since = 3 [deprecated = true];
  google.protobuf.Timestamp start_range = 4;
  google.protobuf.Timestamp end_range = 5;
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@raystack/frontier/v1beta1/frontier.proto` around lines 545 - 549, Add a brief
deprecation comment for the google.protobuf.Timestamp since = 3 [deprecated =
true]; field indicating that callers should use start_range and end_range
instead (mirror the style used in ChangeSubscriptionRequest). Update the comment
adjacent to the since field to mention it was deprecated in favor of
start_range/end_range so future readers know the intended replacement.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@raystack/frontier/v1beta1/frontier.proto`:
- Around line 545-549: Add a brief deprecation comment for the
google.protobuf.Timestamp since = 3 [deprecated = true]; field indicating that
callers should use start_range and end_range instead (mirror the style used in
ChangeSubscriptionRequest). Update the comment adjacent to the since field to
mention it was deprecated in favor of start_range/end_range so future readers
know the intended replacement.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a4345937-c4cb-457a-bb07-efa5a758f400

📥 Commits

Reviewing files that changed from the base of the PR and between 2d162b4 and 611f764.

📒 Files selected for processing (1)
  • raystack/frontier/v1beta1/frontier.proto

@rohilsurana rohilsurana merged commit ac2df19 into main Apr 7, 2026
3 checks passed
@rohilsurana rohilsurana deleted the fix/frontier-revert-deprecated-fields branch April 7, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant