fix(frontier): revert removal of some deprecated fields#468
fix(frontier): revert removal of some deprecated fields#468rohilsurana merged 2 commits intomainfrom
Conversation
…ionRequest and ListBillingTransactionsRequest
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 23 minutes and 12 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughProtocol Buffer schema changes to two message types in the frontier service. Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
raystack/frontier/v1beta1/frontier.proto (1)
545-549: Revertedsincefield looks correct; consider adding a deprecation comment.The revert correctly restores field 3 with the
[deprecated = true]annotation. For consistency with theChangeSubscriptionRequestchanges (which include comments explaining the deprecation), consider adding a brief comment indicating thatstart_range/end_rangeshould be used instead.💡 Optional: Add deprecation comment
reserved 2; + // deprecated in favor of start_range/end_range google.protobuf.Timestamp since = 3 [deprecated = true]; google.protobuf.Timestamp start_range = 4; google.protobuf.Timestamp end_range = 5;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@raystack/frontier/v1beta1/frontier.proto` around lines 545 - 549, Add a brief deprecation comment for the google.protobuf.Timestamp since = 3 [deprecated = true]; field indicating that callers should use start_range and end_range instead (mirror the style used in ChangeSubscriptionRequest). Update the comment adjacent to the since field to mention it was deprecated in favor of start_range/end_range so future readers know the intended replacement.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@raystack/frontier/v1beta1/frontier.proto`:
- Around line 545-549: Add a brief deprecation comment for the
google.protobuf.Timestamp since = 3 [deprecated = true]; field indicating that
callers should use start_range and end_range instead (mirror the style used in
ChangeSubscriptionRequest). Update the comment adjacent to the since field to
mention it was deprecated in favor of start_range/end_range so future readers
know the intended replacement.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a4345937-c4cb-457a-bb07-efa5a758f400
📒 Files selected for processing (1)
raystack/frontier/v1beta1/frontier.proto
Summary
ChangeSubscriptionRequest.plan(field 4) andChangeSubscriptionRequest.immediate(field 5)ListBillingTransactionsRequest.since(field 3)Test plan