feat(frontier): remove deprecated fields and reserve field ids#467
feat(frontier): remove deprecated fields and reserve field ids#467rohilsurana merged 1 commit intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRemoved multiple deprecated scope-identifying and other deprecated fields from request message types in Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
raystack/frontier/v1beta1/frontier.proto (1)
2205-2211:⚠️ Potential issue | 🟡 MinorMark
CheckResourcePermissionRequest.resourceas REQUIRED for consistency.The
resourcefield lacks required validation whilepermissionis marked REQUIRED. Similar patterns elsewhere (e.g.,CheckFederatedResourcePermissionRequest.resourcein admin.proto) show that required resource identifiers are marked with(google.api.field_behavior) = REQUIRED. Consider adding this annotation:message CheckResourcePermissionRequest { reserved 1, 2; string permission = 3 [ (google.api.field_behavior) = REQUIRED, (buf.validate.field).string.pattern = "^[A-Za-z0-9._-]+$" ]; - string resource = 4; + string resource = 4 [(google.api.field_behavior) = REQUIRED]; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@raystack/frontier/v1beta1/frontier.proto` around lines 2205 - 2211, The CheckResourcePermissionRequest message's resource field is missing the required annotation; update the frontier.proto definition for CheckResourcePermissionRequest to add (google.api.field_behavior) = REQUIRED to the string resource field so it matches permission and other requests like CheckFederatedResourcePermissionRequest.resource; locate the resource field in the CheckResourcePermissionRequest message and add the REQUIRED field behavior annotation to enforce validation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@raystack/frontier/v1beta1/frontier.proto`:
- Around line 2205-2211: The CheckResourcePermissionRequest message's resource
field is missing the required annotation; update the frontier.proto definition
for CheckResourcePermissionRequest to add (google.api.field_behavior) = REQUIRED
to the string resource field so it matches permission and other requests like
CheckFederatedResourcePermissionRequest.resource; locate the resource field in
the CheckResourcePermissionRequest message and add the REQUIRED field behavior
annotation to enforce validation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1f473737-0473-48eb-bef6-a7186968523e
📒 Files selected for processing (1)
raystack/frontier/v1beta1/frontier.proto
8596342 to
269ccc0
Compare
Summary
frontier.protoand mark their field numbers asreservedto prevent reuseTest plan