Skip to content

refactor(siren): update subscription and generalize alerts api #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravisuhag merged 2 commits into from
Nov 7, 2022
Merged

refactor(siren): update subscription and generalize alerts api #216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c6bdd7
refactor(siren): update type of configuration to struct in subscription
mabdh Nov 1, 2022
3e995d8
feat(siren): generalize create alerts
mabdh Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 10 additions & 22 deletions odpf/siren/v1beta1/siren.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,15 +275,15 @@ service SirenService {
};
}

rpc CreateCortexAlerts(CreateCortexAlertsRequest) returns (CreateCortexAlertsResponse) {
rpc CreateAlerts(CreateAlertsRequest) returns (CreateAlertsResponse) {
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {
summary: "create cortex alerts";
summary: "create alerts";
tags: "Alert";
};

option (google.api.http) = {
post: "/v1beta1/alerts/cortex/{provider_id}"
body: "*"
post: "/v1beta1/alerts/{provider_type}/{provider_id}"
body: "body"
};
}

Expand Down Expand Up @@ -488,7 +488,7 @@ message DeleteNamespaceResponse {}

message ReceiverMetadata {
uint64 id = 1;
map<string, string> configuration = 4;
google.protobuf.Struct configuration = 4;
}

message Subscription {
Expand Down Expand Up @@ -628,25 +628,13 @@ message ListAlertsResponse {
repeated Alert alerts = 1;
}

message CortexAlert {
map<string, string> annotations = 1;
map<string, string> labels = 2;
string status = 3;
google.protobuf.Timestamp starts_at = 4;
google.protobuf.Timestamp ends_at = 5;
string generator_url = 6;
string fingerprint = 7;
}

message CreateCortexAlertsRequest {
uint64 provider_id = 1;
repeated CortexAlert alerts = 2;
string group_key = 3;
string external_url = 4;
string version = 5;
message CreateAlertsRequest {
string provider_type= 1;
uint64 provider_id = 2;
google.protobuf.Struct body = 3;
}

message CreateCortexAlertsResponse {
message CreateAlertsResponse {
repeated Alert alerts = 1;
}

Expand Down