feat: PAT principal in audit records and auth context#1522
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds Personal Access Token (PAT) support across audit/auth flows: new UserPATService interface and mocks, wiring userPATService into auditrecord service initialization, PAT-based actor enrichment and metadata handling, updates to principal name/title resolution, and corresponding tests and logging key changes. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 245fb3f0-904a-46a2-8959-02fa116eea99
📒 Files selected for processing (15)
cmd/serve.gocore/auditrecord/mocks/repository.gocore/auditrecord/mocks/session_service.gocore/auditrecord/mocks/user_pat_service.gocore/auditrecord/service.gocore/auditrecord/service_test.gocore/authenticate/context.gocore/authenticate/context_test.gocore/authenticate/mocks/user_pat_service.gocore/organization/service.gointernal/api/v1beta1connect/audit_record.gointernal/api/v1beta1connect/preferences.gointernal/api/v1beta1connect/session.gointernal/api/v1beta1connect/user.gopkg/server/connect_interceptors/authentication.go
Coverage Report for CI Build 24175974524Coverage increased (+0.09%) to 41.282%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Summary
Test plan
Sample AuditRecord with PAT: