Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 13 minutes and 35 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds a comprehensive React 19-compatible settings UI infrastructure to the client-demo app and SDK. It introduces nested routing for organization settings, creates new view components (General, Preferences, Profile, Sessions) wrapping Frontier backend views, adds reusable UI building blocks (ImageUpload, ViewContainer, ViewHeader), and updates dependencies to align with React 19. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 17
🧹 Nitpick comments (2)
web/sdk/admin/components/SheetFooter.tsx (1)
9-10: Remove@ts-ignore; type the style object instead.Line 9 suppresses type checking on a core render path and can mask real type regressions. Prefer explicit typing over suppression.
Proposed diff
-import React from "react"; +import type { CSSProperties, ReactNode } from "react"; import { Flex } from "@raystack/apsara"; type SheetFooterProps = { - children?: React.ReactNode; + children?: ReactNode; }; export function SheetFooter({ children }: SheetFooterProps) { - // `@ts-ignore` return <Flex style={styles.footer}>{children}</Flex>; } -const styles = { +const styles: { footer: CSSProperties } = { footer: { bottom: 0, left: 0,web/sdk/react/components/image-upload/image-upload.module.css (1)
26-33: Add keyboard-focus parity for the hover-only avatar reveal.Current behavior is mouse-only. Mirror the same styling for
:focus-visibleso keyboard users get equivalent feedback.Suggested CSS tweak
.iconButton:hover .avatar { opacity: 0; visibility: hidden; } .iconButton:hover { border-color: var(--rs-color-border-accent-primary); } + +.iconButton:focus-visible .avatar { + opacity: 0; + visibility: hidden; +} + +.iconButton:focus-visible { + border-color: var(--rs-color-border-accent-primary); +}
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bc543b83-5f81-4242-ac91-f122765584ac
⛔ Files ignored due to path filters (1)
web/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (42)
web/apps/client-demo/package.jsonweb/apps/client-demo/src/App.tsxweb/apps/client-demo/src/Router.tsxweb/apps/client-demo/src/pages/Home.tsxweb/apps/client-demo/src/pages/Settings.tsxweb/apps/client-demo/src/pages/settings/General.tsxweb/apps/client-demo/src/pages/settings/Preferences.tsxweb/apps/client-demo/src/pages/settings/Profile.tsxweb/apps/client-demo/src/pages/settings/Sessions.tsxweb/apps/client-demo/src/styles.cssweb/sdk/admin/components/SheetFooter.tsxweb/sdk/package.jsonweb/sdk/react/components/image-upload/image-upload.module.cssweb/sdk/react/components/image-upload/image-upload.tsxweb/sdk/react/components/image-upload/index.tsweb/sdk/react/components/view-container/index.tsweb/sdk/react/components/view-container/view-container.module.cssweb/sdk/react/components/view-container/view-container.tsxweb/sdk/react/components/view-header/index.tsweb/sdk/react/components/view-header/view-header.tsxweb/sdk/react/hooks/useSessions.tsweb/sdk/react/index.tsweb/sdk/react/views-new/general/components/delete-organization-dialog.module.cssweb/sdk/react/views-new/general/components/delete-organization-dialog.tsxweb/sdk/react/views-new/general/general-view.module.cssweb/sdk/react/views-new/general/general-view.tsxweb/sdk/react/views-new/general/index.tsweb/sdk/react/views-new/preferences/components/preference-row.tsxweb/sdk/react/views-new/preferences/components/preferences-row.module.cssweb/sdk/react/views-new/preferences/index.tsweb/sdk/react/views-new/preferences/preferences-view.module.cssweb/sdk/react/views-new/preferences/preferences-view.tsxweb/sdk/react/views-new/profile/index.tsweb/sdk/react/views-new/profile/profile-view.module.cssweb/sdk/react/views-new/profile/profile-view.tsxweb/sdk/react/views-new/sessions/components/revoke-session-confirm-dialog.tsxweb/sdk/react/views-new/sessions/components/revoke-session-dialog.module.cssweb/sdk/react/views-new/sessions/components/revoke-session-dialog.tsxweb/sdk/react/views-new/sessions/index.tsweb/sdk/react/views-new/sessions/sessions-view.module.cssweb/sdk/react/views-new/sessions/sessions-view.tsxweb/sdk/tsup.config.ts
web/sdk/react/views-new/sessions/components/revoke-session-confirm-dialog.tsx
Show resolved
Hide resolved
rohanchkrabrty
changed the title
rohanchkrabrty
added
the
Do not merge
web/sdk/react/views-new/sessions/components/revoke-session-confirm-dialog.tsx
Show resolved
Hide resolved
web/sdk/react/views-new/sessions/components/revoke-session-dialog.module.css
Show resolved
Hide resolved
paanSinghCoder
approved these changes
Apr 2, 2026
rohanchkrabrty
removed
the
Do not merge
Pull Request Test Coverage Report for Build 24019484653Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary