Skip to content

feat: React 19 migration - 2#709

Merged
rohanchkrabrty merged 3 commits intomainfrom
migrate-react-19-2
Mar 18, 2026
Merged

feat: React 19 migration - 2#709
rohanchkrabrty merged 3 commits intomainfrom
migrate-react-19-2

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Removes React.forwardRef() wrappers from 10 components (callout through context-menu), using ref-as-prop (React 19 Case A/B pattern)
  • Updates type annotations from ComponentPropsWithoutRef/HTMLAttributesComponentProps to include ref in types
  • Sets correct displayName on all exported components, matching their public export names

Components migrated:

  • callout
  • checkbox
  • code-block
  • collapsible
  • color-picker
  • combobox
  • command
  • container
  • context-menu

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment Mar 17, 2026 9:07pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 296eb3df-5198-4943-9df7-9f64f62c2545

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch migrate-react-19-2
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty changed the title feat: migrate components to React 19 - 2 feat: React 19 migration - 2 Mar 17, 2026
Base automatically changed from migrate-react-19 to main March 18, 2026 06:53
@rohanchkrabrty rohanchkrabrty merged commit 983674b into main Mar 18, 2026
3 checks passed
@rohanchkrabrty rohanchkrabrty deleted the migrate-react-19-2 branch March 18, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants