Coderabbit integration#1908
Conversation
Following on the work of rapidsai/rmm#2244 and rapidsai/cuml#7725, this enables general instructions and configuration to enable coderabbit codereviews on cuvs.
|
fwiw, I found this paper about the effectiveness of AGENTS.md files somewhat interesting (and possibly relevant to this PR) https://arxiv.org/pdf/2602.11988 |
|
/ok to test c1a5bb5 |
aamijar
left a comment
There was a problem hiding this comment.
Looks fine to me, I think once we start getting some coderabbit reviews we can iterate the rules if necessary.
bdice
left a comment
There was a problem hiding this comment.
I am approving (rather than blocking with my suggestions below) because I am convinced that guiding AI agents effectively is very difficult. It requires a high level of experimentation and openness to trying new things. None of us have all the answers yet.
That said, I think if you adopt some of the suggestions (in this PR or a follow-up), you may have a better experience with CodeRabbit and other agents over the long haul. Please give it some consideration.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
|
/ok to test 08238b0 |
|
/merge |
Following on the work of rapidsai/rmm#2244 and rapidsai/cuml#7725, this enables general instructions and configuration to enable coderabbit codereviews on cuvs. Closes rapidsai#1767 Authors: - Ben Frederickson (https://github.com/benfred) - Corey J. Nolet (https://github.com/cjnolet) - Anupam (https://github.com/aamijar) Approvers: - Anupam (https://github.com/aamijar) - Corey J. Nolet (https://github.com/cjnolet) - Bradley Dice (https://github.com/bdice) URL: rapidsai#1908
Add CodeRabbit AI code review configuration and review guidelines for cuDF. - Add `.coderabbit.yaml` configuration for CodeRabbit AI code reviews - Add `cpp/REVIEW_GUIDELINES.md` with C++/CUDA-specific review guidelines for cuDF - Add `python/REVIEW_GUIDELINES.md` with Python-specific review guidelines for cuDF - Update `.github/CODEOWNERS` to assign CI codeowners to `.coderabbit.yaml` - Update `.github/workflows/pr.yaml` to exclude `REVIEW_GUIDELINES.md` and `.coderabbit.yaml` from CI triggers - Update `.agents/skills/review-cudf/SKILL.md` to reference the new `REVIEW_GUIDELINES.md` files instead of duplicating the review checklist inline The file structure separates concerns: - `.coderabbit.yaml` - CodeRabbit configuration (review profile, path instructions, knowledge base) - `cpp/REVIEW_GUIDELINES.md` - CodeRabbit review guidelines for C++/CUDA code - `python/REVIEW_GUIDELINES.md` - CodeRabbit review guidelines for Python code (all packages) - `.agents/skills/review-cudf/SKILL.md` - Agent-based review workflow (now references REVIEW_GUIDELINES.md for checklists) Adapted from rapidsai/rmm#2244 and rapidsai/cuvs#1908. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Muhammad Haseeb (https://github.com/mhaseeb123) URL: #22176
Following on the work of rapidsai/rmm#2244 and rapidsai/cuml#7725, this enables general instructions and configuration to enable coderabbit codereviews on cuvs.
Closes #1767