Skip to content

Coderabbit integration#1908

Merged
rapids-bot[bot] merged 7 commits intorapidsai:mainfrom
benfred:coderabbit
Apr 9, 2026
Merged

Coderabbit integration#1908
rapids-bot[bot] merged 7 commits intorapidsai:mainfrom
benfred:coderabbit

Conversation

@benfred
Copy link
Copy Markdown
Contributor

@benfred benfred commented Mar 10, 2026

Following on the work of rapidsai/rmm#2244 and rapidsai/cuml#7725, this enables general instructions and configuration to enable coderabbit codereviews on cuvs.

Closes #1767

Following on the work of rapidsai/rmm#2244 and
rapidsai/cuml#7725, this enables general
instructions and configuration to enable coderabbit codereviews on cuvs.
@benfred benfred requested review from a team as code owners March 10, 2026 23:55
@benfred benfred requested a review from gforsyth March 10, 2026 23:55
@benfred benfred added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 10, 2026
@benfred
Copy link
Copy Markdown
Contributor Author

benfred commented Mar 10, 2026

fwiw, I found this paper about the effectiveness of AGENTS.md files somewhat interesting (and possibly relevant to this PR) https://arxiv.org/pdf/2602.11988

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 7, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@aamijar
Copy link
Copy Markdown
Member

aamijar commented Apr 7, 2026

/ok to test c1a5bb5

Copy link
Copy Markdown
Member

@aamijar aamijar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, I think once we start getting some coderabbit reviews we can iterate the rules if necessary.

Copy link
Copy Markdown
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving (rather than blocking with my suggestions below) because I am convinced that guiding AI agents effectively is very difficult. It requires a high level of experimentation and openness to trying new things. None of us have all the answers yet.

That said, I think if you adopt some of the suggestions (in this PR or a follow-up), you may have a better experience with CodeRabbit and other agents over the long haul. Please give it some consideration.

Comment thread cpp/agents.md Outdated
Comment thread cpp/agents.md Outdated
Comment thread python/REVIEW_GUIDELINES.md
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@aamijar
Copy link
Copy Markdown
Member

aamijar commented Apr 9, 2026

/ok to test 08238b0

@aamijar aamijar self-assigned this Apr 9, 2026
@aamijar
Copy link
Copy Markdown
Member

aamijar commented Apr 9, 2026

/merge

@rapids-bot rapids-bot Bot merged commit 5e5b20b into rapidsai:main Apr 9, 2026
151 of 155 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Unstructured Data Processing Apr 9, 2026
enp1s0 pushed a commit to enp1s0/cuvs that referenced this pull request Apr 10, 2026
Following on the work of rapidsai/rmm#2244 and rapidsai/cuml#7725, this enables general instructions and configuration to enable coderabbit codereviews on cuvs.

Closes rapidsai#1767

Authors:
  - Ben Frederickson (https://github.com/benfred)
  - Corey J. Nolet (https://github.com/cjnolet)
  - Anupam (https://github.com/aamijar)

Approvers:
  - Anupam (https://github.com/aamijar)
  - Corey J. Nolet (https://github.com/cjnolet)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#1908
rapids-bot Bot pushed a commit to rapidsai/cudf that referenced this pull request Apr 28, 2026
Add CodeRabbit AI code review configuration and review guidelines for cuDF.

- Add `.coderabbit.yaml` configuration for CodeRabbit AI code reviews
- Add `cpp/REVIEW_GUIDELINES.md` with C++/CUDA-specific review guidelines for cuDF
- Add `python/REVIEW_GUIDELINES.md` with Python-specific review guidelines for cuDF
- Update `.github/CODEOWNERS` to assign CI codeowners to `.coderabbit.yaml`
- Update `.github/workflows/pr.yaml` to exclude `REVIEW_GUIDELINES.md` and `.coderabbit.yaml` from CI triggers
- Update `.agents/skills/review-cudf/SKILL.md` to reference the new `REVIEW_GUIDELINES.md` files instead of duplicating the review checklist inline

The file structure separates concerns:
- `.coderabbit.yaml` - CodeRabbit configuration (review profile, path instructions, knowledge base)
- `cpp/REVIEW_GUIDELINES.md` - CodeRabbit review guidelines for C++/CUDA code
- `python/REVIEW_GUIDELINES.md` - CodeRabbit review guidelines for Python code (all packages)
- `.agents/skills/review-cudf/SKILL.md` - Agent-based review workflow (now references REVIEW_GUIDELINES.md for checklists)

Adapted from rapidsai/rmm#2244 and rapidsai/cuvs#1908.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Muhammad Haseeb (https://github.com/mhaseeb123)

URL: #22176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[FEA] Enable code rabbit for AI code reviews

4 participants