Skip to content

fix(taskctl): add timeout enforcement and logging for Composer agent (#394) #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
randomm merged 2 commits into from
Apr 8, 2026
Merged

fix(taskctl): add timeout enforcement and logging for Composer agent (#394) #395

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7eed68
fix(taskctl): add timeout enforcement and logging for Composer agent …
randomm Apr 7, 2026
b8dfd4d
refactor(taskctl): log elapsedMs on composer success (#394)
randomm Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/opencode/src/tasks/composer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import { MessageV2 } from "../session/message-v2"
import { Store } from "./store"
import { Validation } from "./validation"
import { generateUniqueSlug, slugify } from "./tool"
import { Log } from "../util/log"

const log = Log.create({ service: "taskctl.composer" })

const ComposerTasksSchema = z.object({
title: z.string().min(1).max(200),
Expand Down Expand Up @@ -37,6 +40,8 @@ async function defaultSpawnComposerFn(
permission: [],
})

const startTime = Date.now()

// prompt() blocks until the agent finishes
// Race with timeout — if timeout fires, cancel the session cleanly
let timedOut = false
Expand All @@ -48,12 +53,21 @@ async function defaultSpawnComposerFn(
}, timeoutMs),
)

log.info("composer started", { sessionID: session.id, timeoutMs })

await Promise.race([
SessionPrompt.prompt({ sessionID: session.id, agent: "composer", parts: [{ type: "text", text: prompt }] }),
timeoutPromise,
])

if (timedOut) return undefined
const elapsedMs = Date.now() - startTime

if (timedOut) {
log.warn("composer timed out", { sessionID: session.id, elapsedMs })
throw new Error(`Composer timed out after ${timeoutMs / 1000}s. Issue description may be too complex. Consider simplifying.`)
}

log.info("composer completed", { sessionID: session.id, elapsedMs })

// Agent finished — read final assistant message directly from DB
// MessageV2.stream() is descending order — .find() gets the newest assistant message
Expand Down
Loading