Skip to content

feat(explorer): add pager#18

Merged
rande merged 2 commits into
rande:masterfrom
plouc:ftr_explorer_nodes_pager
Dec 28, 2015
Merged

feat(explorer): add pager#18
rande merged 2 commits into
rande:masterfrom
plouc:ftr_explorer_nodes_pager

Conversation

@plouc

@plouc plouc commented Dec 28, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@plouc

plouc commented Dec 28, 2015

Copy link
Copy Markdown
Contributor Author

@rande, the build fail because of vault, do you know how I can fix this ? It's annoying because the explorer tests don't run

@rande

rande commented Dec 28, 2015

Copy link
Copy Markdown
Owner

I think the vault test should be skipped if aws credentials are not set.
On Dec 28, 2015 7:11 PM, "Raphaël Benitte" notifications@github.com wrote:

@rande https://github.com/rande, the build fail because of vault, do
you know how I can fix this ? It's annoying because the explorer tests
don't run


Reply to this email directly or view it on GitHub
#18 (comment).

@plouc

plouc commented Dec 28, 2015

Copy link
Copy Markdown
Contributor Author

@rande any idea on how to achieve this ?

@rande

rande commented Dec 28, 2015

Copy link
Copy Markdown
Owner

Give me 30min I will submit a patch ;)
On Dec 28, 2015 7:32 PM, "Raphaël Benitte" notifications@github.com wrote:

@rande https://github.com/rande any idea on how to achieve this ?


Reply to this email directly or view it on GitHub
#18 (comment).

@rande

rande commented Dec 28, 2015

Copy link
Copy Markdown
Owner

@plouc this commit should solve the problem: 52aaef3

@plouc plouc force-pushed the ftr_explorer_nodes_pager branch from 6909242 to 499e73a Compare December 28, 2015 21:22
@plouc

plouc commented Dec 28, 2015

Copy link
Copy Markdown
Contributor Author

@rande, build passed :)

rande added a commit that referenced this pull request Dec 28, 2015
@rande rande merged commit aa5764f into rande:master Dec 28, 2015
@rande rande mentioned this pull request Dec 28, 2015
28 tasks
@plouc plouc deleted the ftr_explorer_nodes_pager branch December 29, 2015 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants