chore: clean files for PHP 8.4

src/Client/Client.php

@@ -62,15 +62,18 @@ public function sendRequest(RequestInterface $request): ResponseInterface
         return $this->convertCurlSimpleResponse($infos);
     }
 
-    /**
-     * @throws \RuntimeException
-     *
-     * @return false|resource
-     */
-    protected function createCurlSimple(RequestInterface $request)
+    /** @throws \RuntimeException */
+    protected function createCurlSimple(RequestInterface $request): \CurlHandle
     {
         $curlHandle = \curl_init();
 
+        // @codeCoverageIgnoreStart
+        // Not possible to arrive here
+        if ($curlHandle === false) {
+            throw new \RuntimeException();
+        }
+        // @codeCoverageIgnoreEnd
+
         \curl_setopt($curlHandle, \CURLOPT_RETURNTRANSFER, true);
         \curl_setopt($curlHandle, \CURLOPT_HEADER, true);
 
@@ -84,8 +87,7 @@ protected function createCurlSimple(RequestInterface $request)
         return $curlHandle;
     }
 
-    /** @param resource $curlHandle */
-    protected function setProtocolVersion($curlHandle, RequestInterface $request): self
+    protected function setProtocolVersion(\CurlHandle $curlHandle, RequestInterface $request): self
     {
         $version = $request->getProtocolVersion();
 
@@ -97,8 +99,7 @@ protected function setProtocolVersion($curlHandle, RequestInterface $request): s
         return $this;
     }
 
-    /** @param resource $curlHandle */
-    protected function setMethod($curlHandle, RequestInterface $request): self
+    protected function setMethod(\CurlHandle $curlHandle, RequestInterface $request): self
     {
         $method = $request->getMethod();
         if ($method === 'HEAD') {
@@ -112,20 +113,15 @@ protected function setMethod($curlHandle, RequestInterface $request): self
         return $this;
     }
 
-    /** @param resource $curlHandle */
-    protected function setUrl($curlHandle, RequestInterface $request): self
+    protected function setUrl(\CurlHandle $curlHandle, RequestInterface $request): self
     {
         \curl_setopt($curlHandle, \CURLOPT_URL, $request->getUri()->__toString());
 
         return $this;
     }
 
-    /**
-     * @param resource $curlHandle
-     *
-     * @throws \RuntimeException
-     */
-    protected function setBody($curlHandle, RequestInterface $request): self
+    /** @throws \RuntimeException */
+    protected function setBody(\CurlHandle $curlHandle, RequestInterface $request): self
     {
         $body = $request->getBody();
         $bodySize = $body->getSize();
@@ -150,8 +146,7 @@ protected function setBody($curlHandle, RequestInterface $request): self
         return $this;
     }
 
-    /** @param resource $curlHandle */
-    protected function setHeaders($curlHandle, RequestInterface $request): self
+    protected function setHeaders(\CurlHandle $curlHandle, RequestInterface $request): self
     {
         $headersCurl = [];
 
@@ -167,8 +162,7 @@ protected function setHeaders($curlHandle, RequestInterface $request): self
         return $this;
     }
 
-    /** @param resource $curlHandle */
-    protected function setSsl($curlHandle, RequestInterface $request): self
+    protected function setSsl(\CurlHandle $curlHandle, RequestInterface $request): self
     {
         if ($request->getUri()->getScheme() === 'https') {
             if ($this->CAInfosPath['info'] !== null) {
@@ -189,12 +183,10 @@ protected function setSsl($curlHandle, RequestInterface $request): self
     }
 
     /**
-     * @param resource $curlHandle
-     *
      * @throws NetworkException
      * @throws RequestException
      */
-    protected function sendCurlSimple($curlHandle, RequestInterface $request): array
+    protected function sendCurlSimple(\CurlHandle $curlHandle, RequestInterface $request): array
     {
         $data = \curl_exec($curlHandle);
 
@@ -212,12 +204,10 @@ protected function sendCurlSimple($curlHandle, RequestInterface $request): array
     }
 
     /**
-     * @param resource $curlHandle
-     *
      * @throws NetworkException
      * @throws RequestException
      */
-    protected function parseCurlSimpleError($curlHandle, RequestInterface $request): void
+    protected function parseCurlSimpleError(\CurlHandle $curlHandle, RequestInterface $request): void
     {
         $errno = \curl_errno($curlHandle);
 

src/Message/Factory/Factory.php

@@ -23,9 +23,6 @@
 use Rancoud\Http\Message\UploadedFile;
 use Rancoud\Http\Message\Uri;
 
-/**
- * Class Factory.
- */
 class Factory implements RequestFactoryInterface, ResponseFactoryInterface, ServerRequestFactoryInterface, StreamFactoryInterface, UploadedFileFactoryInterface, UriFactoryInterface
 {
     /**
@@ -49,7 +46,7 @@ public function createResponse(int $code = 200, string $reasonPhrase = ''): Resp
      *
      * @throws \InvalidArgumentException
      */
-    public function createResponseBody(int $code = 200, $body = null): Response
+    public function createResponseBody(int $code = 200, mixed $body = null): Response
     {
         return new Response($code, [], $body, '1.1');
     }
@@ -255,12 +252,8 @@ protected static function normalizeFiles(array $files): array
         return $normalized;
     }
 
-    /**
-     * @throws \InvalidArgumentException
-     *
-     * @return array|UploadedFile
-     */
-    protected static function createUploadedFileFromSpec(array $value)
+    /** @throws \InvalidArgumentException */
+    protected static function createUploadedFileFromSpec(array $value): array|UploadedFile
     {
         if (\is_array($value['tmp_name'])) {
             return static::normalizeNestedFileSpec($value);

src/Message/MessageTrait.php

@@ -6,9 +6,6 @@
 
 use Psr\Http\Message\StreamInterface;
 
-/**
- * Trait MessageTrait.
- */
 trait MessageTrait
 {
     protected static string $patternHeaderName = "@^[!#$%&'*+.^_`|~0-9A-Za-z-]+$@";
@@ -176,12 +173,8 @@ protected function setHeaders(array $headers): void
         }
     }
 
-    /**
-     * @param array|string $header
-     *
-     * @throws \InvalidArgumentException
-     */
-    protected function validateAndTrimHeader($header, $values): array
+    /** @throws \InvalidArgumentException */
+    protected function validateAndTrimHeader(array|string $header, $values): array
     {
         if (!\is_string($header) || \preg_match(static::$patternHeaderName, $header) !== 1) {
             throw new \InvalidArgumentException('Header name must be RFC 7230 compatible string.');

src/Message/Request.php

@@ -8,25 +8,21 @@
 use Psr\Http\Message\StreamInterface;
 use Psr\Http\Message\UriInterface;
 
-/**
- * Class Request.
- */
 class Request implements RequestInterface
 {
     use MessageTrait;
     use RequestTrait;
 
     /**
-     * @param string|UriInterface                  $uri
      * @param resource|StreamInterface|string|null $body
      *
      * @throws \InvalidArgumentException
      */
     public function __construct(
         string $method,
-        $uri,
+        string|UriInterface $uri,
         array $headers = [],
-        $body = null,
+        mixed $body = null,
         string $version = '1.1'
     ) {
         $this->method = $this->filterMethod($method);

src/Message/RequestTrait.php

@@ -6,9 +6,6 @@
 
 use Psr\Http\Message\UriInterface;
 
-/**
- * Trait RequestTrait.
- */
 trait RequestTrait
 {
     public static array $methods = [

src/Message/Response.php

@@ -7,15 +7,12 @@
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\StreamInterface;
 
-/**
- * Class Response.
- */
 class Response implements ResponseInterface
 {
     use MessageTrait;
 
     /** @var string[] */
-    public const PHRASES = [
+    public const array PHRASES = [
         100 => 'Continue',
         101 => 'Switching Protocols',
         102 => 'Processing',
@@ -188,7 +185,7 @@ class Response implements ResponseInterface
     public function __construct(
         int $status = 200,
         array $headers = [],
-        $body = null,
+        mixed $body = null,
         string $version = '1.1',
         ?string $reason = null
     ) {

src/Message/ServerRequest.php

@@ -9,9 +9,6 @@
 use Psr\Http\Message\UploadedFileInterface;
 use Psr\Http\Message\UriInterface;
 
-/**
- * Class ServerRequest.
- */
 class ServerRequest implements ServerRequestInterface
 {
     use MessageTrait;
@@ -21,8 +18,7 @@ class ServerRequest implements ServerRequestInterface
 
     protected array $cookieParams = [];
 
-    /** @var array|object|null */
-    protected $parsedBody;
+    protected array|object|null $parsedBody = null;
 
     protected array $queryParams = [];
 
@@ -32,16 +28,15 @@ class ServerRequest implements ServerRequestInterface
     protected array $uploadedFiles = [];
 
     /**
-     * @param string|UriInterface                  $uri
      * @param resource|StreamInterface|string|null $body
      *
      * @throws \InvalidArgumentException
      */
     public function __construct(
         string $method,
-        $uri,
+        string|UriInterface $uri,
         array $headers = [],
-        $body = null,
+        mixed $body = null,
         string $version = '1.1',
         array $serverParams = []
     ) {
@@ -150,9 +145,7 @@ public function getAttribute(string $name, $default = null)
         return $this->attributes[$name];
     }
 
-    /**
-     * @throws \InvalidArgumentException
-     */
+    /** @throws \InvalidArgumentException */
     public function withAttribute(string $name, $value): self
     {
         $new = clone $this;
@@ -174,9 +167,7 @@ public function withoutAttribute(string $name): self
         return $new;
     }
 
-    /**
-     * @throws \InvalidArgumentException
-     */
+    /** @throws \InvalidArgumentException */
     protected function validateData($data): void
     {
         if (!\is_array($data) && !\is_object($data) && $data !== null) {

src/Message/Stream.php

@@ -8,13 +8,10 @@
 
 use Psr\Http\Message\StreamInterface;
 
-/**
- * Class Stream.
- */
 class Stream implements StreamInterface
 {
     /** @var array */
-    protected const READ_WRITE_HASH = [
+    protected const array READ_WRITE_HASH = [
         'read' => [
             'r'   => true, 'w+' => true, 'r+' => true, 'x+' => true, 'c+' => true,
             'rb'  => true, 'w+b' => true, 'r+b' => true, 'x+b' => true,
@@ -284,7 +281,7 @@ public function getMetadata(?string $key = null)
      *
      * @throws \InvalidArgumentException
      */
-    public static function create($content = ''): StreamInterface
+    public static function create(mixed $content = ''): StreamInterface
     {
         if ($content instanceof StreamInterface) {
             return $content;
@@ -336,7 +333,7 @@ public static function createFromFile(string $filename, string $mode = 'r'): Str
         try {
             $resource = \fopen($filename, $mode);
             // @codeCoverageIgnoreStart
-        } catch (\Throwable $e) {
+        } catch (\Throwable) {
             // Could not reach this statement without mocking the filesystem
             throw new \RuntimeException(\sprintf('The file %s cannot be opened.', $filename));
             // @codeCoverageIgnoreEnd

src/Message/UploadedFile.php

@@ -7,13 +7,10 @@
 use Psr\Http\Message\StreamInterface;
 use Psr\Http\Message\UploadedFileInterface;
 
-/**
- * Class UploadedFile.
- */
 class UploadedFile implements UploadedFileInterface
 {
     /** @var int[] */
-    protected const ERRORS = [
+    protected const array ERRORS = [
         \UPLOAD_ERR_OK         => 1,
         \UPLOAD_ERR_INI_SIZE   => 1,
         \UPLOAD_ERR_FORM_SIZE  => 1,
@@ -25,7 +22,7 @@ class UploadedFile implements UploadedFileInterface
     ];
 
     /** @var int */
-    protected const DEFAULT_MAX_BYTES_LENGTH = 1048576;
+    protected const int DEFAULT_MAX_BYTES_LENGTH = 1048576;
 
     protected ?string $clientFilename;
 
@@ -47,7 +44,7 @@ class UploadedFile implements UploadedFileInterface
      * @throws \InvalidArgumentException
      */
     public function __construct(
-        $streamOrFile,
+        mixed $streamOrFile,
         ?int $size,
         int $errorStatus,
         ?string $clientFilename = null,
@@ -140,9 +137,7 @@ public function getFilename(): ?string
         return $this->file;
     }
 
-    /**
-     * @throws \InvalidArgumentException
-     */
+    /** @throws \InvalidArgumentException */
     protected function setStreamOrFile($streamOrFile): void
     {
         if (\is_string($streamOrFile)) {