Skip to content

Implement useConciseSubjectLines #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spdiswal merged 2 commits into from
Apr 12, 2026
Merged

Implement useConciseSubjectLines #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
053c6cc
Implement `useConciseSubjectLines`
spdiswal Mar 29, 2026
80e23cb
Justify messages to the right when fitting
spdiswal Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/domains/configurations/Configuration.fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export function fakeConfiguration(overrides: ConfigurationTemplate = {}): Config
useCapitalisedSubjectLines: {},
useCommitterEmailPatterns: {},
useCommitterNamePatterns: {},
useConciseSubjectLines: {},
useConciseSubjectLines: { maxLength: 50 },
useEmptyLineBeforeBodyLines: {},
useImperativeSubjectLines: {},
useIssueLinks: {},
Expand Down
4 changes: 2 additions & 2 deletions src/domains/configurations/GetConfiguration.tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ describe("the default configuration in the command-line", () => {
${"noUnexpectedPunctuation"} | ${{}}
${"noUnexpectedWhitespace"} | ${{}}
${"useCapitalisedSubjectLines"} | ${{}}
${"useConciseSubjectLines"} | ${{}}
${"useConciseSubjectLines"} | ${{ maxLength: 50 }}
${"useEmptyLineBeforeBodyLines"} | ${{}}
${"useImperativeSubjectLines"} | ${{}}
${"useLineWrapping"} | ${{}}
Expand Down Expand Up @@ -78,7 +78,7 @@ describe("the default configuration in GitHub Actions", () => {
${"noUnexpectedPunctuation"} | ${{}}
${"noUnexpectedWhitespace"} | ${{}}
${"useCapitalisedSubjectLines"} | ${{}}
${"useConciseSubjectLines"} | ${{}}
${"useConciseSubjectLines"} | ${{ maxLength: 50 }}
${"useEmptyLineBeforeBodyLines"} | ${{}}
${"useImperativeSubjectLines"} | ${{}}
${"useLineWrapping"} | ${{}}
Expand Down
4 changes: 2 additions & 2 deletions src/domains/configurations/GetDefaultConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function getDefaultCliConfiguration(): Configuration {
useCapitalisedSubjectLines: {},
useCommitterEmailPatterns: null,
useCommitterNamePatterns: null,
useConciseSubjectLines: {},
useConciseSubjectLines: { maxLength: 50 },
useEmptyLineBeforeBodyLines: {},
useImperativeSubjectLines: {},
useIssueLinks: null,
Expand Down Expand Up @@ -63,7 +63,7 @@ function getDefaultGhaConfiguration(): Configuration {
useCapitalisedSubjectLines: {},
useCommitterEmailPatterns: null,
useCommitterNamePatterns: null,
useConciseSubjectLines: {},
useConciseSubjectLines: { maxLength: 50 },
useEmptyLineBeforeBodyLines: {},
useImperativeSubjectLines: {},
useIssueLinks: null,
Expand Down
3 changes: 2 additions & 1 deletion src/domains/rules/UseCapitalisedSubjectLines.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { Commit, Commits } from "#commits/Commit.ts"
import { isText } from "#commits/tokens/Token.ts"
import type { Concern, Concerns } from "#rules/concerns/Concern.ts"
import { subjectLineConcern } from "#rules/concerns/SubjectLineConcern.ts"
import { type RuleContext, ruleContext } from "#rules/Rule.ts"
Expand All @@ -21,7 +22,7 @@ function verifyCommit(commit: Commit, rule: RuleContext): Concern | null {
let index = 0

for (const token of commit.subjectLine) {
if (typeof token === "string") {
if (isText(token)) {
const trimmedToken = token.trimStart()

if (startsWithLowercaseLetter(trimmedToken)) {
Expand Down
Loading
Loading