removes smart quotes for favicon in inst/BS5/templates/head.html#3006
Open
njtierney wants to merge 4 commits into
Open
removes smart quotes for favicon in inst/BS5/templates/head.html#3006njtierney wants to merge 4 commits into
njtierney wants to merge 4 commits into
Conversation
maelle
reviewed
Jul 8, 2026
maelle
left a comment
maelle
left a comment
Collaborator
There was a problem hiding this comment.
Good catch! Could you please add a NEWS item?
maelle
force-pushed
the
fix-smart-quote-i3005
branch
from
July 8, 2026 13:53
754338e to
f74cd18
Compare
Author
|
I shall! But I also need to make sure I fix the other remaining smart quote in the repo! |
Author
|
OK done, thank you @maelle :) |
maelle
reviewed
Jul 13, 2026
| * Test fix for `R CMD check`. | ||
| * When previewing a site, it is now served via a local http server. This enables dynamic features such as search to work correctly (@shikokuchuo, #2975). | ||
| * Code in a link (href) is no longer autolinked (#2972) | ||
| * Ensure SVG favicons are parsed properly by fixing a bug in BS5 and BS3 favicon icon templates where curly/smart quotes (”…”, U+201D) were used instead of straight quotes, which caused the SVG favicon to not be used and a fallback raster favicon to be used. If your fallback was low resolution, your favicon looked poor (@njtierney, #3005). |
Collaborator
There was a problem hiding this comment.
Thanks! Could you please move this item to the dev version section above? Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3005
Strangely I could not pull the /inst/BS5/templates/head.html file locally, unsure if the inst directories are managed differently?