truncate split lists in error logs using PrettySample#6315
Open
truncate split lists in error logs using PrettySample#6315
Conversation
When many splits fail during a search query, the error logs dump every failed split (with its full error message) into a single log line. At scale (hundreds of splits per query), this produces multi-KB unreadable log lines. Use PrettySample(5) to show only the first 5 items and a count of the rest, matching the pattern already used for split_offsets in leaf search. Also adds num_failed_splits/num_splits fields for easy filtering without parsing the sample. Files changed: - root.rs: failed_splits in leaf search response (debug + error) - list_terms.rs: failed_splits in list terms response - fetch_docs.rs: split_ids on fetch docs error Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PrettySample::new(&splits, 5)to show only the first 5 items + a count, matching the existing pattern inleaf.rs:1782num_failed_splits/num_splitsfields for easy grep/alertingBefore (hundreds of splits failing):
After:
Files changed
root.rs—failed_splitsin leaf search response (debug log + rate-limited error)list_terms.rs—failed_splitsin list terms responsefetch_docs.rs—split_idson fetch docs error (also avoids cloning split IDs)Test plan
cargo check -p quickwit-searchpasses🤖 Generated with Claude Code