Skip to content

[CORRUPTED] Synthetic Benchmark PR #74108 - Make Switching to the Search Page Faster#80

Open
tomerqodo wants to merge 28 commits into
base_pr_74108_20251230_1163from
corrupted_pr_74108_20251230_1163
Open

[CORRUPTED] Synthetic Benchmark PR #74108 - Make Switching to the Search Page Faster#80
tomerqodo wants to merge 28 commits into
base_pr_74108_20251230_1163from
corrupted_pr_74108_20251230_1163

Conversation

@tomerqodo

@tomerqodo tomerqodo commented Dec 30, 2025

Copy link
Copy Markdown

Benchmark PR Expensify#74108

Type: Corrupted (contains bugs)

Original PR Title: Make Switching to the Search Page Faster
Original PR Description:

Explanation of Change

Thanks to cleaning up the structure of the search page component, we were able to speed up the time it takes to switch to the Search tab. Below are metrics from several platforms as an example of the time gains:

Desktop web : 2.1s → 1.1s

iOS native ‎ : 6,04s → 4.5s

This shows that we’re managing to save roughly half of the time previously needed to switch tabs on the web, and also more than 1 second on the native platform.

dekompozycja.mp4

Fixed Issues

$ Expensify#74613
PROPOSAL:

Tests

  1. Go to the Search tab.

  2. Check whether the results are displayed correctly.

  3. Make sure you can correctly open all the filters

  4. Verify you can select multiple expense / reports and open the options for bulk actions

  • Verify that no errors appear in the JS console

Offline tests

unnesesary

QA Steps

Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
Screen.Recording.2025-11-14.at.15.55.21.mov
iOS: Native
Screen.Recording.2025-11-14.at.15.15.02.mov
iOS: mWeb Safari
Screen.Recording.2025-11-14.at.15.04.23.mov
MacOS: Chrome / Safari
dekompozycja.1.mov
MacOS: Desktop
Screen.Recording.2025-11-14.at.16.07.07.mov

Original PR URL: Expensify#74108

sumo-slonik and others added 28 commits October 29, 2025 13:16
@sumo-slonik
refactor and cleanUp of searchPage
fcfd3c8
@sumo-slonik
working on selecton preloadas
e305c8c
@sumo-slonik
Merge branch 'refs/heads/main' into feature/kuba-nowakowski/preload_r…
35198e9 
…eports_v2

# Conflicts:
#	src/libs/Navigation/AppNavigator/usePreloadFullScreenNavigators.ts
@sumo-slonik
remove unnecessary console logs and fix skeletons loading
0e5c64d
@sumo-slonik
Merge branch 'main' into feature/kuba-nowakowski/preload_reports_v2
2356ab3
@sumo-slonik
finish work
fea745e
@sumo-slonik
use animated view to make smoother experience
019fe18
@sumo-slonik
remove unnecessary changes
baff7a1
@sumo-slonik
rollback comments in search page
0401f08
@sumo-slonik
rollback changes in SearchAutocompletedList
816adad
@sumo-slonik
Merge branch 'main' into feature/kuba-nowakowski/preload_reports_v2
1669c46 
# Conflicts:
#	src/libs/Navigation/AppNavigator/usePreloadFullScreenNavigators.ts
@sumo-slonik
trigger search onFocus event
7d6e71a
@sumo-slonik
fix ts
df8644d
@sumo-slonik
Merge branch 'main' into feature/kuba-nowakowski/preload_reports_v2
8489f5c
@sumo-slonik
remove all preload features
8d6b12c
@sumo-slonik
Merge branch 'main' into feature/kuba-nowakowski/preload_reports_v2
be437e1 
# Conflicts:
#	src/pages/Search/SearchPage.tsx
@sumo-slonik
clean up comments
2ba0e6e
@sumo-slonik
fix mobile UI glitch
dc18a02
@sumo-slonik
fix expensicons import
3e479ce
@sumo-slonik
fix suggestions
aa01b15
@sumo-slonik
fix suggestions
7d9c976
@sumo-slonik
fix FullPageNotFoundView bug
fd22d6b
@sumo-slonik
fix offline layout
1b9683b
@sumo-slonik
fix shouldShowOfflineIndicatorInWideScreen
fabaf63
@sumo-slonik
fix offlineIndicatorStyle
d8afcad
@sumo-slonik
Merge branch 'main' into feature/kuba-nowakowski/preload_reports_v2
ee420e5 
# Conflicts:
#	src/pages/Search/SearchPage.tsx
#	src/pages/Search/SearchPageNarrow.tsx
@sumo-slonik
fix dependency array
259c295
@tomerqodo
Apply changes for benchmark PR
68ae682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomerqodo @sumo-slonik