feat: add MPS device support to auto_dataloader pin_memory logic#3764
Closed
Aanushka001 wants to merge 1 commit into
Closed
feat: add MPS device support to auto_dataloader pin_memory logic#3764Aanushka001 wants to merge 1 commit into
Aanushka001 wants to merge 1 commit into
Conversation
Collaborator
|
Same, this PR contains irrelevant and inappropriate changes unrelated to the topic of the PR. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the
auto_dataloader()function to also enablepin_memoryfor MPS (Apple Silicon) devices, not just CUDA devices. This ensures data loading performance is optimized when using Apple Silicon GPUs.Changes
auto_dataloader()docstring to mention MPSpin_memorydefault logic to check for MPS devicesRelated
Based on original PR #3763