Partial fix for PDF doc build#2044
Merged
einarf merged 10 commits intopythonarcade:developmentfrom Apr 16, 2024
Merged
Conversation
Member
Author
|
The test failures appear to be |
pvcraven
reviewed
Apr 11, 2024
0406a93 to
05b01f7
Compare
da450f9 to
587c4fc
Compare
Member
Author
|
Rebased onto development to include #2062. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: replaced 403ing images + added gif converter, but LaTex still broken
Changes
camo.githubusercontentimageconvertextension for PDF to convert gifsWhat's Still Broken / Untested
PDF Build: Still Broken
Running
./make.py latexpdfproduces plenty of warnings and ends with this error and a LaTeX input prompt:EPUB build: Untested
Haven't gotten to this yet.