doc_stack/google_style_docstrings#1858
Merged
cspotcode merged 2 commits intodevelopmentfrom Aug 23, 2023
Merged
Conversation
22 tasks
cspotcode
force-pushed
the
doc_stack/sidebar
branch
3 times, most recently
from
24c19eb to
3f70871
Compare
cspotcode
force-pushed
the
doc_stack/google_style_docstrings
branch
from
fe0ad4d to
9127b0c
Compare
cspotcode
force-pushed
the
doc_stack/sidebar
branch
from
3f70871 to
468a053
Compare
cspotcode
force-pushed
the
doc_stack/google_style_docstrings
branch
from
9127b0c to
0ff95a7
Compare
cspotcode
force-pushed
the
doc_stack/sidebar
branch
from
468a053 to
eefd435
Compare
cspotcode
force-pushed
the
doc_stack/google_style_docstrings
branch
from
1b871b3 to
40df0d4
Compare
cspotcode
changed the base branch from
doc_stack/sidebar
to
doc_stack/no_types_in_docstrings
cspotcode
force-pushed
the
doc_stack/no_types_in_docstrings
branch
from
5329c85 to
23eacf3
Compare
cspotcode
force-pushed
the
doc_stack/google_style_docstrings
branch
from
40df0d4 to
264222c
Compare
cspotcode
force-pushed
the
doc_stack/no_types_in_docstrings
branch
from
23eacf3 to
77b2803
Compare
cspotcode
force-pushed
the
doc_stack/google_style_docstrings
branch
from
264222c to
7c4ce7a
Compare
cspotcode
force-pushed
the
doc_stack/no_types_in_docstrings
branch
from
77b2803 to
b3576f1
Compare
cspotcode
force-pushed
the
doc_stack/google_style_docstrings
branch
from
7c4ce7a to
03a2694
Compare
cspotcode
force-pushed
the
doc_stack/no_types_in_docstrings
branch
from
b3576f1 to
6c7407c
Compare
cspotcode
force-pushed
the
doc_stack/google_style_docstrings
branch
from
03a2694 to
408324d
Compare
cspotcode
force-pushed
the
doc_stack/no_types_in_docstrings
branch
from
6c7407c to
e41d5c6
Compare
cspotcode
force-pushed
the
doc_stack/google_style_docstrings
branch
from
408324d to
db944d7
Compare
cspotcode
force-pushed
the
doc_stack/no_types_in_docstrings
branch
from
e41d5c6 to
e73cafe
Compare
cspotcode
force-pushed
the
doc_stack/google_style_docstrings
branch
from
db944d7 to
5705d0f
Compare
pushfoo
approved these changes
Aug 16, 2023
Member
There was a problem hiding this comment.
EDIT: Once the stack is ready, this will be good to merge.
This PR should be good to merge. Multiple people have confirmed this as working before we got momentum going behind migrating to Google-style docstrings. My own branch is one example of many, and not even the first.
My minor nitpick is the three build warnings, but they're also present in the previous PR in the stack.
Collaborator
Author
|
Thanks, if the build warnings were present in the previous PR in the stack, then they were probably introduced by a previous PR in the stack. As a reminder to everyone, don't merge this PR! Only review please. |
22 tasks
cspotcode
force-pushed
the
doc_stack/no_types_in_docstrings
branch
from
e73cafe to
86e4450
Compare
cspotcode
force-pushed
the
doc_stack/google_style_docstrings
branch
from
5705d0f to
d173c63
Compare
cspotcode
force-pushed
the
doc_stack/no_types_in_docstrings
branch
from
86e4450 to
5b696de
Compare
cspotcode
force-pushed
the
doc_stack/google_style_docstrings
branch
from
d173c63 to
a74a993
Compare
cspotcode
changed the base branch from
doc_stack/no_types_in_docstrings
to
development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the PR stack described by #1797