Pass most conformance tests for Zuban#2139
Merged
JelleZijlstra merged 8 commits intopython:mainfrom Jan 8, 2026
Merged
Conversation
… bound of the class
…luation" Reverted because this change was not according to the spec. This reverts commit 593d74d.
davidhalter
force-pushed
the
zuban-update2
branch
2 times, most recently
from
d66cdb2 to
474b63e
Compare
davidhalter
force-pushed
the
zuban-update2
branch
from
474b63e to
c0f41c8
Compare
Contributor
Author
|
@JelleZijlstra Thanks for reviewing! I created a new release and ran the automated tests again. Feel free to merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This latest update passes most conformance tests for Zuban. I simplified the flags for
zuban checkand it also passes 2 more tests for Pyrefly.I have made several small changes to the tests. These should mostly be uncontroversial:
SelfTypeVar = TypeVar("SelfTypeVar", bound=Foo7[int]); Callable[[SelfTypevar], SelfTypeVar]instead ofCallable[[Foo7[int]], Foo7[int]]. I personally believe this should be how we infer things, since it's more precise but I don't think we have to mandate this.list[Any]instead ofAnyin an overload, if there was no match, because both of the overloads return a list and it is therefore just a slightly more precise type.__init__). There is already an error for the outer attributex, but I feel like this error should be fine.There remain 4 non-passing tests for Zuban, all of which I'm not sure the tests are doing the right thing. I will be discussing these in the typing discourse.