ArgumentParser's add_argument returns the Action that was created.#1881
Merged
JelleZijlstra merged 3 commits intopython:masterfrom Mar 29, 2018
Merged
ArgumentParser's add_argument returns the Action that was created.#1881JelleZijlstra merged 3 commits intopython:masterfrom
JelleZijlstra merged 3 commits intopython:masterfrom
Conversation
Member
|
Here's what I think we should do:
|
EvanKrall
added a commit
to EvanKrall/mypy
that referenced
this pull request
Feb 16, 2018
These are made unnecessary by python/typeshed#1881
Contributor
Author
|
Running typeshed's mypy_selftest.py against the PR'd version of both mypy and typeshed results in: It appears that (same behavior in 3.6.1). dest=None handled here:
I guess I'll also change dest to |
…ument should also return the Action.
JelleZijlstra
approved these changes
Feb 17, 2018
emmatyping
approved these changes
Mar 27, 2018
Member
emmatyping
left a comment
There was a problem hiding this comment.
Look forward to this and python/mypy#4578 :)
msullivan
pushed a commit
to python/mypy
that referenced
this pull request
Apr 4, 2018
These are made unnecessary by python/typeshed#1881
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
…ython#1881) * ArgumentParser's add_argument returns the Action that was created. * Make add_argument's dest parameter Optional. _ArgumentGroup's add_argument should also return the Action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1878
I added the member variables of Action to fix this error with mypy_selftest:
However, currently I'm getting:
I suppose to fix this I would have to remove the
type: ignoreline in mypy (now that it's unnecessary), but it seems that would cause a chicken-and-egg problem: such a PR against mypy would fail tests until this PR is merged.