Enable generation and caching of fine-grained dependencies from normal runs#4526
Merged
Enable generation and caching of fine-grained dependencies from normal runs#4526
Conversation
gvanrossum
reviewed
Jan 31, 2018
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Basically LG, two stylistic nits.
mypy/build.py
Outdated
| elif dep not in self.suppressed and dep in self.manager.missing_modules: | ||
| self.suppressed.append(dep) | ||
|
|
||
| def find_fine_grained_deps(self) -> None: |
Member
There was a problem hiding this comment.
Would you mind renaming this so the name more clearly implies that it has a side-effect?
mypy/build.py
Outdated
|
|
||
|
|
||
| def write_cache(id: str, path: str, tree: MypyFile, | ||
| fine_grained_deps: Dict[str, List[str]], |
Member
There was a problem hiding this comment.
I'd rename this to serialized_fine_grained_deps just to clarify that it does not have the same type as State.fine_grained_deps (List vs. Set).
gvanrossum
approved these changes
Jan 31, 2018
carljm
added a commit
to carljm/mypy
that referenced
this pull request
Feb 14, 2018
* master: (32 commits) Fix some fine-grained cache/fswatcher problems (python#4560) Sync typeshed (python#4559) Add _cached suffix to test cases in fine-grained tests with cache (python#4558) Add back support for simplified fine-grained logging (python#4557) Type checking of class decorators (python#4544) Sync typeshed (python#4556) When loading from a fine-grained cache, use the real path, not the cached (python#4555) Switch all of the fine-grained debug logging to use manager.log (python#4550) Caching for fine-grained incremental mode (python#4483) Fix --warn-return-any for NotImplemented (python#4545) Remove myunit (python#4369) Store line numbers of imports in the cache metadata (python#4533) README.md: Fix a typo (python#4529) Enable generation and caching of fine-grained dependencies from normal runs (python#4526) Move argument parsing for the fine-grained flag into the main arg parsing code (python#4524) Don't warn about unrecognized options starting with 'x_' (python#4522) stubgen: don't append star arg when args list already has varargs appended (python#4518) Handle TypedDict in diff and deps (python#4510) Fix Options.__repr__ to not infinite recurse (python#4514) Fix some fine-grained incremental bugs with newly imported files (python#4502) ...
8 tasks
yedpodtrzitko
pushed a commit
to kiwicom/mypy
that referenced
this pull request
Mar 15, 2018
This was discovered in python#4403. I thought I'd add it while I am splitting changes out of that PR. It was originally introduced in python#4526 but not added to the docs it seems. (the rest of the diff is due to my using an actual output of the help command from master)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.