Include ambiguous into UninhabitedType identity#19648
Merged
ilevkivskyi merged 4 commits intopython:masterfrom Aug 14, 2025
Merged
Include ambiguous into UninhabitedType identity#19648ilevkivskyi merged 4 commits intopython:masterfrom
ambiguous into UninhabitedType identity#19648ilevkivskyi merged 4 commits intopython:masterfrom
Conversation
…xing that to another PR, but this one only passed due to `foo` definition, removing it also causes failure on master
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Yeah, I think we should deny this (i.e. |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Collaborator
Author
|
Ough, yes, we definitely should deny that - only inline empty collection literals should receive special treatment. https://mypy-play.net/?mypy=latest&python=3.12&flags=strict&gist=2000dac04e592ad8b92012aa697cdbe6 |
ilevkivskyi
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19641, but also reveals a test that was only passing by coincidence. This inference has never worked correctly:
As discussed, I updated the test to expect failure in that case. We should only special-case inline collection literals for that, everything else (including locals) can cause undesired false negatives.
Cc @ilevkivskyi as the original author (#16122)