bpo-33951: IDLE test_configdialog: call page.update() in setUpClass#7892
Merged
terryjreedy merged 1 commit intopython:masterfrom Jun 24, 2018
Merged
Conversation
This avoids a failure in at least one case when running only a single test method rather than all tests in the module. The issue came up when testing the following on Windows 10 Pro 64-bit: HighPageTest.test_highlight_target_text_mouse
terryjreedy
approved these changes
Jun 24, 2018
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
Additions may or may not all be needed, but I do not believe they can hurt and the detected problem is fixed.
Thank you for thinking of this.
terryjreedy
changed the title
Member
|
Shorten title while adding 'IDLE' |
Contributor
|
Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-7896 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 24, 2018
…thonGH-7892) This avoids a failure in at least one case when running only a single test method rather than all tests in the module. The issue came up when testing the following on Windows 10 Pro 64-bit: HighPageTest.test_highlight_target_text_mouse (cherry picked from commit 2af9f5d) Co-authored-by: Tal Einat <taleinat+github@gmail.com>
|
GH-7897 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 24, 2018
…thonGH-7892) This avoids a failure in at least one case when running only a single test method rather than all tests in the module. The issue came up when testing the following on Windows 10 Pro 64-bit: HighPageTest.test_highlight_target_text_mouse (cherry picked from commit 2af9f5d) Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Jun 24, 2018
…-7892) This avoids a failure in at least one case when running only a single test method rather than all tests in the module. The issue came up when testing the following on Windows 10 Pro 64-bit: HighPageTest.test_highlight_target_text_mouse (cherry picked from commit 2af9f5d) Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Jun 24, 2018
…-7892) This avoids a failure in at least one case when running only a single test method rather than all tests in the module. The issue came up when testing the following on Windows 10 Pro 64-bit: HighPageTest.test_highlight_target_text_mouse (cherry picked from commit 2af9f5d) Co-authored-by: Tal Einat <taleinat+github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a consistent failure in at least one case when running only a single test method rather than all tests in the module.
The issue came up when running the following on Windows 10 Pro 64-bit:
python -m test -ugui -m test_highlight_target_text_mouse test_idle(This test failed for perhaps an unrelated reason on Travis CI for GH-7887. I encountered the issue while investigating that failure.)
https://bugs.python.org/issue33951