gh-91338: Ensure test_ucnhash_capi_reset doesn't pass PYTHONHOME to _testembed.exe#32313
Closed
neonene wants to merge 3 commits intopython:mainfrom
neonene:nohome
Closed
gh-91338: Ensure test_ucnhash_capi_reset doesn't pass PYTHONHOME to _testembed.exe#32313neonene wants to merge 3 commits intopython:mainfrom neonene:nohome
neonene wants to merge 3 commits intopython:mainfrom
neonene:nohome
Conversation
tiran
approved these changes
Apr 4, 2022
Member
|
Looks good to me! |
Contributor
Author
|
@zooba, could you take a look at this? |
Member
|
We have a few other tests that use the same function. I'd assume we either need to update all of them (because they're all "wrong", even if they're not triggering it yet), or make sure that the values aren't regenerated differently. Do we know the root cause of the changed value? |
Contributor
Author
|
Holding the value of |
Contributor
Author
I'll close this and open an issue, considering that the current behavior, which I think is practical, may be unintentional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor tweak for Windows.
_test_embed.exefails to import*.pydmodules when the initialization is repeated withPYTHONHOMEfrompython.bat.sys.pathat Loop#1 has the build directory, which is replaced withf"{PYTHONHOME}/DLLs"at the next loop. The behavior looks realistically designed.GitHub CI machines doesn't show the error, using
rt.batwherePYTHONHOMEis not set.https://bugs.python.org/issue47182