[3.10] gh-143935: Email preserve parens when folding comments (GH-143936)#144350
Open
edgarrmondragon wants to merge 1 commit intopython:3.10from
Open
[3.10] gh-143935: Email preserve parens when folding comments (GH-143936)#144350edgarrmondragon wants to merge 1 commit intopython:3.10from
edgarrmondragon wants to merge 1 commit intopython:3.10from
Conversation
bedevere-app
bot
added
awaiting review
topic-email
type-security
edgarrmondragon
force-pushed
the
backport-17d1490-3.10
branch
from
555694d to
6da28a1
Compare
…ythonGH-143936) Fix a bug in the folding of comments when flattening an email message using a modern email policy. Comments consisting of a very long sequence of non-foldable characters could trigger a forced line wrap that omitted the required leading space on the continuation line, causing the remainder of the comment to be interpreted as a new header field. This enabled header injection with carefully crafted inputs. (cherry picked from commit 17d1490) Co-authored-by: Seth Michael Larson [email protected] Co-authored-by: Denis Ledoux [email protected] - Issue: Fix folding of long comments of unfoldable characters in email headers python#143935 Signed-off-by: Edgar Ramírez Mondragón <[email protected]>
edgarrmondragon
force-pushed
the
backport-17d1490-3.10
branch
from
6da28a1 to
d4a7858
Compare
Contributor
Author
|
would you mind taking a look @sethmlarson? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in the folding of comments when flattening an email message using a modern email policy. Comments consisting of a very long sequence of non-foldable characters could trigger a forced line wrap that omitted the required leading space on the continuation line, causing the remainder of the comment to be interpreted as a new header field. This enabled header injection with carefully crafted inputs.
(cherry picked from commit 17d1490)
Co-authored-by: Seth Michael Larson [email protected]
Co-authored-by: Denis Ledoux [email protected]