gh-129005: Remove copies from _pyio using take_bytes#141539
Merged
vstinner merged 2 commits intopython:mainfrom Nov 18, 2025
Merged
gh-129005: Remove copies from _pyio using take_bytes#141539vstinner merged 2 commits intopython:mainfrom
vstinner merged 2 commits intopython:mainfrom
Conversation
Memory usage now matches that of _io for large files
Contributor
Author
|
Optimization enabled by gh-139871 (Trying to keep that one issue referencing all the things which I use it for; planning to expand the What's New with a single "here's all the modules that got faster" list once optimize) |
vstinner
reviewed
Nov 17, 2025
| @@ -620,15 +620,15 @@ def read(self, size=-1): | |||
| if n < 0 or n > len(b): | |||
| raise ValueError(f"readinto returned {n} outside buffer size {len(b)}") | |||
| del b[n:] | |||
Member
There was a problem hiding this comment.
Is there a difference between b.resize(n) and del b[n:]?
Contributor
Author
There was a problem hiding this comment.
.resize() could grow while the del b[n:] never will. There's some code which does a = bytearray(b'12'); del a[3:] (intentionally del a slice past the end) as part of its buffer management. Generally I prefer resize because there's a lot less code involved than the slice code (and the slice code eventually calls resize anyways)
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…1539) Memory usage now matches that of _io for large files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memory usage now matches that of _io for large files.
For reference; this test goes from 8.5sec overall duration on my AMD 64 bit Arch Linux box to 7 seconds.