gh-46376: minimal fix for setting pointers via pointers in ctypes#136876
Open
code-of-kpp wants to merge 1 commit intopython:mainfrom
Open
gh-46376: minimal fix for setting pointers via pointers in ctypes#136876code-of-kpp wants to merge 1 commit intopython:mainfrom
code-of-kpp wants to merge 1 commit intopython:mainfrom
Conversation
Contributor
Author
63e12c5 to
a42ad21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous attempts to address the oldest open issue (gh-46376) were a bit too ambitious.
Here, I tackle half of the problem: the segfaults.
There’s still a soft memory leak (objects previously assigned to pointer contents are kept in
_objects). It’s completely unclear how to fix these and if it’s even possible at all. This situation is similar tocast(), where we don’t know anymore if the memory can be cleaned if the object wascasted at least once.A new idea is that in some cases, specifically when we have pointer, structure, array, or union assignment to pointer’s
contents, we will save the RHS value object into pointer’sb_base. We only need to do this whenb_baseisNULL/Noneor when we are in a chain of pointers that start from another pointer created directly with apointer()call (so NOT as part of structure, union, etc.).