gh-69605: Disable PyREPL module autocomplete fallback on regular completion#134181
Merged
ambv merged 7 commits intopython:mainfrom May 25, 2025
Merged
Conversation
When no module completions are available, do not fallback to completions from current namespace
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
tomasr8
reviewed
May 18, 2025
Member
tomasr8
left a comment
tomasr8
left a comment
There was a problem hiding this comment.
Nice! Overall approach looks good, I just have some nitpicks 🙂
Misc/NEWS.d/next/Core_and_Builtins/2025-05-18-14-33-23.gh-issue-69605.ZMO49F.rst
Outdated
Show resolved
Hide resolved
|
Thanks @loic-simon for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 25, 2025
…r completion (pythongh-134181) (cherry picked from commit 0e3bc96) Co-authored-by: Loïc Simon <loic.pano@gmail.com> Co-authored-by: Loïc Simon <loic.simon@napta.io>
|
GH-134680 is a backport of this pull request to the 3.14 branch. |
ambv
pushed a commit
that referenced
this pull request
May 25, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…r completion (pythongh-134181) Co-authored-by: Loïc Simon <loic.simon@napta.io>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…r completion (pythongh-134181) Co-authored-by: Loïc Simon <loic.simon@napta.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no module completions are available, do not fallback on completions from current namespace, as there are not relevant.
Before:
After:
cc @tomasr8