Skip to content

GH-131678: fix Windows tail-call CI does not run the test cases#131690

Merged
Fidget-Spinner merged 2 commits intopython:mainfrom
chris-eibl:windows_tail_call_yml
Mar 28, 2025
Merged

GH-131678: fix Windows tail-call CI does not run the test cases#131690
Fidget-Spinner merged 2 commits intopython:mainfrom
chris-eibl:windows_tail_call_yml

Conversation

@chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented Mar 24, 2025

@chris-eibl
Copy link
Member Author

I think this is a skip news?

@hugovk
Copy link
Member

hugovk commented Mar 25, 2025

Yes, label added.

Thanks for the PR!

Although test_mmap is failing, let's deal with that first, cc @Fidget-Spinner.

@chris-eibl
Copy link
Member Author

chris-eibl commented Mar 25, 2025

Yeah, I have already created an issue for the failing test #131691

@chris-eibl
Copy link
Member Author

#131691 was fixed and merged (in case this was blocking).

IMHO, this is good to merge: it now runs the test cases - and they are green?

@Fidget-Spinner Fidget-Spinner merged commit ce77da5 into python:main Mar 28, 2025
44 checks passed
@chris-eibl chris-eibl deleted the windows_tail_call_yml branch March 28, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants