GH-130396: Use computed stack limits on linux#130398
Merged
markshannon merged 22 commits intopython:mainfrom Feb 25, 2025
Merged
GH-130396: Use computed stack limits on linux#130398markshannon merged 22 commits intopython:mainfrom
markshannon merged 22 commits intopython:mainfrom
Conversation
markshannon
force-pushed
the
gnu-stack-overflow-check
branch
2 times, most recently
from
ec4cc83 to
6b48afe
Compare
markshannon
added
the
🔨 test-with-buildbots
markshannon
requested review from
Eclips4,
brandtbucher,
corona10,
ericsnowcurrently,
erlend-aasland,
iritkatriel and
rhettinger
as code owners
markshannon
removed
the
🔨 test-with-buildbots
Member
Author
|
!buildbot .* |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 12f9ce7 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
brandtbucher
approved these changes
Feb 21, 2025
Member
brandtbucher
left a comment
brandtbucher
left a comment
There was a problem hiding this comment.
I'm definitely not an expert in this particular area, but the changes seem reasonable (provided the buildbots are happy).
Comment on lines
25
to
27
| * no two calls to check recursion depth are more than this far | ||
| * apart. In practice, that means it must be larger than the C | ||
| * stack consumption of PyEval_EvalDefault */ |
Member
There was a problem hiding this comment.
This seems sort of fragile? What if there's a ton of unrelated C calls (maybe from a C extension) between two interpreter entries? Does that cause this to be incorrect?
Member
Author
There was a problem hiding this comment.
Any C code that can recurse needs to do checks.
We already do that in plenty of places, like the parser, compiler, json encoding, etc.
C extensions should do it too.
Member
Author
|
Ignoring prior failures and timesouts, the buildbot fialures are webassembly stack overflows and a couple of odd AIX failures. |
picnixz
reviewed
Feb 22, 2025
Misc/NEWS.d/next/Core_and_Builtins/2025-02-21-11-12-41.gh-issue-130396.SIenSP.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Core_and_Builtins/2025-02-21-11-12-41.gh-issue-130396.SIenSP.rst
Outdated
Show resolved
Hide resolved
Member
Author
|
!buildbot was[i|m] |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit f6002e5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Member
Author
|
!buildbot AIX |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit f6002e5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
picnixz
reviewed
Feb 23, 2025
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 415906c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Member
Author
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 415906c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Member
Author
|
Compilation failures on both AIX buildbots, but unrelated to this PR. |
Member
Author
|
!buildbot wasm |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 415906c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Member
Author
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit b3ccffc 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Member
Author
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit a2c1656 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Member
Author
|
!buildbot wasm |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit a2c1656 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Member
Author
|
!buildbot wasm |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit a2c1656 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
|
This was referenced Mar 21, 2025
Merged
Member
|
FYI, this introduced a new warning in MSVC: so I don't think the attempts to hide the taking of the address of the stack variable work on MSVC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technically, not just linux, but any platform with
pthread_getattr_np.