gh-118761: Improve import time of subprocess#129427
Merged
gpshead merged 2 commits intopython:mainfrom Jan 29, 2025
Merged
Conversation
AA-Turner
approved these changes
Jan 29, 2025
gpshead
approved these changes
Jan 29, 2025
Member
gpshead
left a comment
gpshead
left a comment
There was a problem hiding this comment.
thanks for including the comments in the code as to why. as much as a dislike it from a style perspective, this is the right way to get faster import times in Python today.
gpshead
added
needs backport to 3.12
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 29, 2025
* subprocess: lazy import signal and locale to improve module import time (cherry picked from commit 49f2465) Co-authored-by: Taneli Hukkinen <3275109+hukkin@users.noreply.github.com>
|
GH-129447 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 29, 2025
* subprocess: lazy import signal and locale to improve module import time (cherry picked from commit 49f2465) Co-authored-by: Taneli Hukkinen <3275109+hukkin@users.noreply.github.com>
|
GH-129448 is a backport of this pull request to the 3.12 branch. |
|
|
Contributor
|
The iOS test failure is weird - yes, it failed in a stress test... but it then passed on a re-run. Not sure why it's reported as a fail (and a fail without identifying the failing test...) It doesn't look like a problem though. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
* subprocess: lazy import signal and locale to improve module import time
gpshead
added a commit
to gpshead/cpython
that referenced
this pull request
Feb 16, 2025
…H-129427)" This reverts commit 49f2465. This caused bugs in the `__del__` finalizer: python#118761 (comment)
gpshead
added a commit
that referenced
this pull request
Feb 16, 2025
…130201) * Revert "gh-118761: Improve import time of `subprocess` (GH-129427)" This reverts commit 49f2465. Also known as f502c8f in 3.13 (PR #129447) Also known as f65aa0d in 3.12 (PR #129448) This caused bugs in the `__del__` finalizer: #118761 (comment) --------- Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 16, 2025
…H-129427)" (pythonGH-130201) * Revert "pythongh-118761: Improve import time of `subprocess` (pythonGH-129427)" This reverts commit 49f2465. Also known as f502c8f in 3.13 (PR pythonGH-129447) Also known as f65aa0d in 3.12 (PR pythonGH-129448) This caused bugs in the `__del__` finalizer: python#118761 (comment) --------- (cherry picked from commit ae30646) Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 16, 2025
…H-129427)" (pythonGH-130201) * Revert "pythongh-118761: Improve import time of `subprocess` (pythonGH-129427)" This reverts commit 49f2465. Also known as f502c8f in 3.13 (PR pythonGH-129447) Also known as f65aa0d in 3.12 (PR pythonGH-129448) This caused bugs in the `__del__` finalizer: python#118761 (comment) --------- (cherry picked from commit ae30646) Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
gpshead
added a commit
that referenced
this pull request
Feb 16, 2025
)" (GH-130201) (#130205) gh-118761: Revert "Improve import time of `subprocess` (GH-129427)" (GH-130201) * Revert "gh-118761: Improve import time of `subprocess` (GH-129427)" This reverts commit 49f2465. Also known as f502c8f in 3.13 (PR GH-129447) Also known as f65aa0d in 3.12 (PR GH-129448) This caused bugs in the `__del__` finalizer: #118761 (comment) --------- (cherry picked from commit ae30646) Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
gpshead
added a commit
that referenced
this pull request
Feb 16, 2025
)" (GH-130201) (#130204) gh-118761: Revert "Improve import time of `subprocess` (GH-129427)" (GH-130201) * Revert "gh-118761: Improve import time of `subprocess` (GH-129427)" This reverts commit 49f2465. Also known as f502c8f in 3.13 (PR GH-129447) Also known as f65aa0d in 3.12 (PR GH-129448) This caused bugs in the `__del__` finalizer: #118761 (comment) --------- (cherry picked from commit ae30646) Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
import subprocesslazy importlocaleandsignal. As a result, alsore(imported bylocale) andenum(imported bysignal) imports are skipped.Benchmark import time
mainbranchPR branch
Benchmark
subprocess.runcallIn fact, this not only has an effect on import time, but simple
subprocess.runcalls, too:mainbranchPR branch