gh-123165: correct tests for dis.dis(func, show_positions=True)#123220
Merged
iritkatriel merged 2 commits intopython:mainfrom Aug 22, 2024
Merged
gh-123165: correct tests for dis.dis(func, show_positions=True)#123220iritkatriel merged 2 commits intopython:mainfrom
dis.dis(func, show_positions=True)#123220iritkatriel merged 2 commits intopython:mainfrom
Conversation
Member
The same way that dis tests '--' for line numbers should work. It inputs python code that gets compiled into something that needs '--'. |
Member
Author
Mmh, yes it was dumb of me. I'll try this approach now. |
Member
Author
|
The tests are a bit longer (in length) but at least I don't need some magical construction that I would forget about tomorrow :D Thank you all for the tips. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark suggested simplifying the faking of positions information via
astmanipulation so here it is.cc @iritkatriel @markshannon
show_positionskeyword argument todis.disand related functions #123165