gh-119182: Optimize PyUnicode_FromFormat()#120796
Merged
vstinner merged 3 commits intopython:mainfrom Jun 20, 2024
Merged
Conversation
Use strchr() and ucs1lib_find_max_char() to optimize the code path formatting sub-strings between '%' formats.
Member
Author
|
Results of #120248 (comment) benchmark: |
Objects/unicodeobject.c
Outdated
| } | ||
|
|
||
| if (_PyUnicodeWriter_WriteASCIIString(writer, f, len) < 0) | ||
| int is_ascii = (ucs1lib_find_max_char((Py_UCS1*)f, (Py_UCS1*)f + len) < 128); |
Member
There was a problem hiding this comment.
You can run it once, for the whole format string.
Member
Author
There was a problem hiding this comment.
Right. I modified my PR to run it only once, good idea!
Member
Author
|
Merged, thanks for the reviews @serhiy-storchaka. |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
Use strchr() and ucs1lib_find_max_char() to optimize the code path formatting sub-strings between '%' formats.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Use strchr() and ucs1lib_find_max_char() to optimize the code path formatting sub-strings between '%' formats.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Use strchr() and ucs1lib_find_max_char() to optimize the code path formatting sub-strings between '%' formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use strchr() and ucs1lib_find_max_char() to optimize the code path formatting sub-strings between '%' formats.