gh-115911: Ignore PermissionError during import from cwd#116131
Merged
jaraco merged 7 commits intopython:mainfrom Jan 26, 2025
Merged
gh-115911: Ignore PermissionError during import from cwd#116131jaraco merged 7 commits intopython:mainfrom
jaraco merged 7 commits intopython:mainfrom
Conversation
moreati
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
moreati
force-pushed
the
issue115911
branch
2 times, most recently
from
8b1cbd4 to
ff4dfda
Compare
moreati
force-pushed
the
issue115911
branch
2 times, most recently
from
c026bb9 to
10ebce0
Compare
Contributor
Author
|
The new test fails (as intended) without the accompanying fix. Local test run on macOS 14.3.1 |
jaraco
reviewed
Jun 20, 2024
moreati
force-pushed
the
issue115911
branch
2 times, most recently
from
c48c021 to
f06124d
Compare
jaraco
reviewed
Aug 29, 2024
Member
jaraco
left a comment
jaraco
left a comment
There was a problem hiding this comment.
Looks good to me, but I'd like to see another review from someone more familiar with importlib internals.
|
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
moreati
force-pushed
the
issue115911
branch
2 times, most recently
from
f4d5e67 to
03f2dd6
Compare
On macOS `getcwd(3)` can return EACCES if a path component isn't readable, resulting in PermissionError. `PathFinder.find_spec()` now catches these and ignores them - the same treatment as a missing/deleted cwd. Introduces `test.support.os_helper.save_mode(path, ...)`, a context manager that restores the mode of a path on exit. This is allows finer control of exception handling and robust environment restoration across platforms in `FinderTests.test_permission_error_cwd()`. Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> Co-authored-by: Brett Cannon <brett@python.org>
Contributor
Author
|
Failure |
Contributor
Author
|
@brettcannon I believe I've made the changes you requested. Please could you take another look? |
jaraco
approved these changes
Jan 26, 2025
Member
jaraco
left a comment
jaraco
left a comment
There was a problem hiding this comment.
Given that you address Brett's changes, I'm inclined to push this forward. We can revisit (and revert) if necessary.
jaraco
dismissed
brettcannon’s stale review
Concerns were addressed. Let's proceed.
|
Contributor
Author
|
I think the buildbot failure is a flaky test, atleast on that runner. Of the 5 previous builds 3 failed on this test (3138, 3139, 3140) have failed in the same test, 2 succeeded (3142, 3143). Trying to reproduce the failure locally I saw it with the revision from this PR (a8dc6d6), but not previous revision in main (914c232). |
Contributor
Author
|
A second local run with rev a8dc6d6 has succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS
getcwd(3)can return EACCES if a path component isn't readable, resulting in PermissionError.PathFinder.find_spec()now catches these and ignores them - the same treatment as a missing/deleted cwd.Introduces
test.support.os_helper.save_mode(path, ...), a context manager that restores the mode of a path on exit.This is allows finer control of exception handling and robust environment restoration across platforms in
FinderTests.test_permission_error_cwd().Fixes #115911
📚 Documentation preview 📚: https://cpython-previews--116131.org.readthedocs.build/