Skip to content

gh-107265: Fix _PyFrame_OpAlreadyRan for ENTER_EXECUTOR case#111645

Closed
corona10 wants to merge 3 commits intopython:mainfrom
corona10:gh-107265-_PyFrame_OpAlreadyRan
Closed

gh-107265: Fix _PyFrame_OpAlreadyRan for ENTER_EXECUTOR case#111645
corona10 wants to merge 3 commits intopython:mainfrom
corona10:gh-107265-_PyFrame_OpAlreadyRan

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Nov 2, 2023

@corona10
Copy link
Member Author

corona10 commented Nov 2, 2023

_PyFrame_OpAlreadyRan is only called for MAKE_CELL right now.
So it might be a low possibility that it will make an issue in the current situation.
But it should handle ENTER_EXECUTOR opcode case when comparing the opcode.

@gvanrossum
Copy link
Member

I will have to delay reviewing this, but my immediate reaction is that we want to make this function unnecessary, not more complicated.

@corona10
Copy link
Member Author

corona10 commented Nov 2, 2023

I will have to delay reviewing this, but my immediate reaction is that we want to make this function unnecessary, not more complicated.

Yeah, I also agree that way too.

@corona10 corona10 closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments