gh-111417: Remove unused code block in math.trunc() and builtin_round_impl#111454
Merged
serhiy-storchaka merged 1 commit intopython:mainfrom Feb 3, 2024
Merged
gh-111417: Remove unused code block in math.trunc() and builtin_round_impl#111454serhiy-storchaka merged 1 commit intopython:mainfrom
serhiy-storchaka merged 1 commit intopython:mainfrom
Conversation
Member
|
I suggest adding some text explaining reasons for removal. Either in the commit message or in the pr description (which may become a commit message). |
willingc
reviewed
Oct 29, 2023
Misc/NEWS.d/next/Library/2023-10-29-11-51-04.gh-issue-111417.LkmWKc.rst
Outdated
Show resolved
Hide resolved
willingc
reviewed
Oct 29, 2023
Contributor
Author
|
@serhiy-storchaka sorry for asking but any thoughts? |
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
As I have said on the issue, this change looks safe to me. Do you mind to remove also a similar code in round()?
Misc/NEWS.d/next/Library/2023-10-29-11-51-04.gh-issue-111417.LkmWKc.rst
Outdated
Show resolved
Hide resolved
Jason-Y-Z
force-pushed
the
fix-issue-111417
branch
from
3048741 to
9716a15
Compare
Jason-Y-Z
changed the title
Contributor
Author
Sorry for the delay, I've made the updates. @serhiy-storchaka |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…pythonGH-111454) _PyObject_LookupSpecial() now ensures that the type is ready.
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
…pythonGH-111454) _PyObject_LookupSpecial() now ensures that the type is ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused code block in
math.trunc()andbuiltin_round_implas mentioned in #111417