gh-107805: Fix signatures of module-level generated functions in `turtle` by sobolevn · Pull Request #107807 · python/cpython

sobolevn · 2023-08-09T10:52:23Z

Now we are using inspect.signature which works correct for all possible parameter types.
There are no / params to test it, but it uses the same branch as regular pos-or-keyword params, so it should be fine.

Related #103974

Issue: turtle.teleport has incorrect-ish signature #107805

…n `turtle`

sobolevn · 2023-08-09T10:54:22Z

I think that this can go into rc2, because it fixes a bug which makes turtle.teleport unusable.

gpshead

likely good, but i'll take a closer look tomorrow. one suggestion added.

Lib/turtle.py

bedevere-bot · 2023-08-10T06:30:41Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

gpshead · 2023-08-10T18:02:17Z

Lib/test/test_turtle.py

+            'pen': '(pen=None, **pendict)',
+        }
+
+        for name in turtle.__all__:


The purpose of this test is only to verify known signatures, correct?

In that case, looping over known_signatures.items() rather than turtle.__all__ makes more sense. Otherwise a typo in a known_signatures name key would go silently unnoticed and we're otherwise creating subtests for all names in turtle even though most of them don't test anything.

serhiy-storchaka

Well, I think that it would be nice to add also tests for the original issue:

Call teleport() without arguments.
Call teleport() with three positional arguments (it should fail).

bedevere-bot · 2023-08-18T07:30:08Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

sobolevn · 2023-08-21T15:03:27Z

I've addressed @gpshead comments about the test case, but I don't think that I can actually test these functions:

Nothing similar is tested in test_turtle, it simply does not have any Turtle class tests at all
I don't know anything about tkinter
I don't really think that we should add test foundation for it in this specific PR
inspect works with real python function signature, so it is at least something

If anyone wants to contribute some tkinter-based tests for Turtle class, I would be happy to include teleport test there 👍

serhiy-storchaka

Well, testing module-level turtle function is a non-trivial task.

gpshead

I manually tested that turtle.Turtle() appears to work and that Turtle.teleport works.

miss-islington · 2023-09-01T08:18:19Z

Thanks @sobolevn for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

…n `turtle` (pythonGH-107807) (cherry picked from commit 044b8b3) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-bot · 2023-09-01T08:18:29Z

GH-108749 is a backport of this pull request to the 3.12 branch.

…in `turtle` (GH-107807) (#108749) gh-107805: Fix signatures of module-level generated functions in `turtle` (GH-107807) (cherry picked from commit 044b8b3) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

pythongh-107805: Fix signatures of module-level generated functions i…

40ee61d

…n `turtle`

sobolevn requested review from gpshead and terryjreedy August 9, 2023 10:52

bedevere-bot added the awaiting review label Aug 9, 2023

bedevere-bot mentioned this pull request Aug 9, 2023

turtle.teleport has incorrect-ish signature #107805

Closed

sobolevn added 2 commits August 9, 2023 14:12

Fix CI

03ea67d

Fix CI

7f71ffd

gpshead added type-bug An unexpected behavior, bug, or error needs backport to 3.12 only security fixes release-blocker labels Aug 10, 2023

gpshead self-assigned this Aug 10, 2023

gpshead requested changes Aug 10, 2023

View reviewed changes

Lib/turtle.py Outdated Show resolved Hide resolved

bedevere-bot added awaiting changes and removed awaiting review labels Aug 10, 2023

sobolevn added 2 commits August 10, 2023 09:42

Use patma

43f131f

Better error message

51f5bf0

serhiy-storchaka approved these changes Aug 11, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Aug 11, 2023

gpshead reviewed Aug 18, 2023

View reviewed changes

serhiy-storchaka requested changes Aug 18, 2023

View reviewed changes

bedevere-bot removed the awaiting merge label Aug 18, 2023

bedevere-bot added the awaiting changes label Aug 18, 2023

Address review

438dcbc

Merge branch 'main' into issue-107805

ac50e7f

serhiy-storchaka approved these changes Aug 27, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Aug 27, 2023

gpshead approved these changes Sep 1, 2023

View reviewed changes

gpshead merged commit 044b8b3 into python:main Sep 1, 2023

bedevere-bot removed the awaiting merge label Sep 1, 2023

bedevere-bot removed the needs backport to 3.12 only security fixes label Sep 1, 2023

adorilson mentioned this pull request Jun 28, 2025

Create tests for turtle module #135272

Open

21 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-107805: Fix signatures of module-level generated functions in `turtle`#107807

gh-107805: Fix signatures of module-level generated functions in `turtle`#107807
gpshead merged 7 commits intopython:mainfrom
sobolevn:issue-107805

sobolevn commented Aug 9, 2023 •

edited by bedevere-bot

Loading

Uh oh!

sobolevn commented Aug 9, 2023

Uh oh!

gpshead left a comment

Uh oh!

Uh oh!

bedevere-bot commented Aug 10, 2023

Uh oh!

gpshead Aug 10, 2023

Uh oh!

serhiy-storchaka left a comment

Uh oh!

bedevere-bot commented Aug 18, 2023

Uh oh!

sobolevn commented Aug 21, 2023

Uh oh!

serhiy-storchaka left a comment

Uh oh!

gpshead left a comment

Uh oh!

miss-islington commented Sep 1, 2023

Uh oh!

bedevere-bot commented Sep 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

sobolevn commented Aug 9, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sobolevn commented Aug 9, 2023

Uh oh!

gpshead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Aug 10, 2023

Uh oh!

gpshead Aug 10, 2023

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Aug 18, 2023

Uh oh!

sobolevn commented Aug 21, 2023

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

gpshead left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Sep 1, 2023

Uh oh!

bedevere-bot commented Sep 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sobolevn commented Aug 9, 2023 •

edited by bedevere-bot

Loading