Skip to content

gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis becoming immortal#105195

Merged
iritkatriel merged 8 commits intopython:mainfrom
iritkatriel:immortals-doc
Jun 21, 2023
Merged

gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis becoming immortal#105195
iritkatriel merged 8 commits intopython:mainfrom
iritkatriel:immortals-doc

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jun 1, 2023 •
edited by github-actions bot
Loading

@iritkatriel iritkatriel added the needs backport to 3.12 only security fixes label Jun 1, 2023
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jun 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 1, 2023
Closed
@iritkatriel
Copy link
Member Author

iritkatriel commented Jun 1, 2023

CC @eduardo-elizondo .

@eduardo-elizondo eduardo-elizondo mentioned this pull request Jun 4, 2023
Closed
@corona10 corona10 mentioned this pull request Jun 5, 2023
Merged
JelleZijlstra
JelleZijlstra previously requested changes Jun 5, 2023
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Jun 5, 2023

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

iritkatriel
iritkatriel commented Jun 5, 2023
View reviewed changes
@iritkatriel
Copy link
Member Author

iritkatriel commented Jun 21, 2023

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Jun 21, 2023

Thanks for making the requested changes!

@erlend-aasland, @JelleZijlstra: please review the changes made to this pull request.

carljm
carljm reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few more broken references to fix.

Since bool.rst is such a small file I'd be tempted to also just fix in passing the two erroring references to Py_True and Py_False near the top of the file (line 9), but that's up to you; that line isn't changed in the PR otherwise.

iritkatriel and others added 2 commits June 21, 2023 19:12
@iritkatriel @carljm
Apply suggestions from code review
7330a7f 
Co-authored-by: Carl Meyer <carl@oddbird.net>
@iritkatriel
fix :const:->:c:data:
4281b5b
@iritkatriel iritkatriel dismissed JelleZijlstra’s stale review June 21, 2023 20:12

Changes made and approved by other reviewers.

@iritkatriel iritkatriel merged commit a239272 into python:main Jun 21, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jun 21, 2023

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jun 21, 2023

GH-105977 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2023
@iritkatriel @miss-islington
pythongh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis b…
4446a42 
…ecoming immortal (pythonGH-105195)

(cherry picked from commit a239272)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
bentasker pushed a commit to bentasker/cpython that referenced this pull request Jun 23, 2023
@iritkatriel @bentasker
pythongh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis b…
40a23a1 
…ecoming immortal (python#105195)
kumaraditya303 pushed a commit that referenced this pull request Jun 26, 2023
@miss-islington @iritkatriel
[3.12] gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis …
592d1ea 
…becoming immortal (GH-105195) (#105977)

gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis becoming immortal (GH-105195)
(cherry picked from commit a239272)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@iritkatriel iritkatriel deleted the immortals-doc branch July 25, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iritkatriel @bedevere-bot @miss-islington @carljm @JelleZijlstra @erlend-aasland