gh-68654: Clarify subdirectories used by pkgutil.extend_path#103701
Merged
CAM-Gerlach merged 1 commit intopython:mainfrom Apr 22, 2023
Merged
gh-68654: Clarify subdirectories used by pkgutil.extend_path#103701CAM-Gerlach merged 1 commit intopython:mainfrom
CAM-Gerlach merged 1 commit intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
san-juan1667
force-pushed
the
gh-686545-clarify-extend_path
branch
from
360260a to
ec040e2
Compare
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
CAM-Gerlach
added
docs
san-juan1667
changed the title
CAM-Gerlach
approved these changes
Apr 22, 2023
Member
There was a problem hiding this comment.
LGTM, thanks @san-juan1667 ! Congratulations on your first PR to CPython (and maybe my first ever commit)!
CAM-Gerlach
changed the title
Contributor
|
Thanks @san-juan1667 for the PR, and @CAM-Gerlach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 22, 2023
…ythonGH-103701) Clarify sub directories used by pkgutil.extend_path in the docs and the docstring (cherry picked from commit 7bf9456) Co-authored-by: Randy <69558016+san-juan1667@users.noreply.github.com>
|
GH-103702 is a backport of this pull request to the 3.11 branch. |
Member
|
Line 85 Warning: ModuleSpec is a class in importlib.machinery. Add 'importlib.machinery' to get rid of the warning. An easy fix if still sprinting tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarified sub directories used by pkgutil extend_path in docs and doc string