gh-99108: Followup fix for Modules/Setup#102183
Merged
miss-islington merged 1 commit intopython:mainfrom Feb 23, 2023
Merged
Conversation
msprotz
requested review from
a team,
corona10,
erlend-aasland and
tiran
as code owners
msprotz
force-pushed
the
protz_md5_sha1
branch
from
11579fc to
db3ae84
Compare
asottile
approved these changes
Feb 23, 2023
Contributor
asottile
left a comment
asottile
left a comment
There was a problem hiding this comment.
no idea why the cpython suite doesn't fail -- my guess is it doesn't use this file
Contributor
Author
|
thanks -- do you mind adding a skip-news label, too? |
Contributor
|
|
Contributor
afaict that file is correct (and validated because it gets used by the testsuite) |
erlend-aasland
approved these changes
Feb 23, 2023
Contributor
|
Status check is done, and it's a success ✅. |
Member
|
I personally don't know why Modules/Setup even exists anymore, I thought the .in file template replaced it. |
Contributor
Yes, true. I'm not sure if |
JelleZijlstra
pushed a commit
to JelleZijlstra/cpython
that referenced
this pull request
Sep 10, 2024
Automerge-Triggered-By: GH:erlend-aasland
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automerge-Triggered-By: GH:erlend-aasland