Skip to content

Comments

GH-100892: Fix race in clearing threading.local#100922

Merged
kumaraditya303 merged 5 commits intopython:mainfrom
kumaraditya303:tstate
Jan 11, 2023
Merged

GH-100892: Fix race in clearing threading.local#100922
kumaraditya303 merged 5 commits intopython:mainfrom
kumaraditya303:tstate

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jan 10, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jan 10, 2023
Closed
@kumaraditya303 kumaraditya303 added needs backport to 3.10 only security fixes type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.11 only security fixes labels Jan 10, 2023
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Jan 10, 2023

This race exists in security only branches too, @ambv how about backporting this to those?

@kumaraditya303 kumaraditya303 requested a review from ambv January 10, 2023 14:14
kumaraditya303
kumaraditya303 commented Jan 10, 2023
View reviewed changes
@pablogsal
Copy link
Member

pablogsal commented Jan 10, 2023 •
edited
Loading

Excellent job @kumaraditya303 👌

pablogsal
pablogsal reviewed Jan 10, 2023
View reviewed changes
pablogsal
pablogsal reviewed Jan 10, 2023
View reviewed changes
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Jan 11, 2023

Excellent job👌

Thanks for the review, I have added a test and verified it, will merge once CI passes.

@kumaraditya303 kumaraditya303 merged commit 762745a into python:main Jan 11, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@kumaraditya303 kumaraditya303 deleted the tstate branch January 11, 2023 10:33
@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Sorry @kumaraditya303, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 762745a124cbc297cf2fe6f3ec9ca1840bb2e873 3.11

@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Sorry, @kumaraditya303, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 762745a124cbc297cf2fe6f3ec9ca1840bb2e873 3.10

@kumaraditya303 kumaraditya303 added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 11, 2023
@kumaraditya303 kumaraditya303 added the needs backport to 3.11 only security fixes label Jan 11, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Sorry @kumaraditya303, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 762745a124cbc297cf2fe6f3ec9ca1840bb2e873 3.10

@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Sorry, @kumaraditya303, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 762745a124cbc297cf2fe6f3ec9ca1840bb2e873 3.11

@bedevere-bot
Copy link

bedevere-bot commented Jan 11, 2023

GH-100937 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 11, 2023
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jan 11, 2023
@kumaraditya303
[3.11] pythonGH-100892: Fix race in clearing threading.local (pytho…
21dd695 
…nGH-100922).

(cherry picked from commit 762745a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 11, 2023

GH-100938 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 11, 2023
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jan 11, 2023
@kumaraditya303
[3.10] pythonGH-100892: Fix race in clearing threading.local (pytho…
683e9fe 
…nGH-100922).

(cherry picked from commit 762745a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 11, 2023

GH-100939 is a backport of this pull request to the 3.9 branch.

1 similar comment
@bedevere-bot
Copy link

bedevere-bot commented Jan 11, 2023

GH-100939 is a backport of this pull request to the 3.9 branch.

kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jan 11, 2023
@kumaraditya303
[3.9] [3.10] pythonGH-100892: Fix race in clearing threading.local (p…
0bbdd31 
…ythonGH-100922).

(cherry picked from commit 762745a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>.
(cherry picked from commit 683e9fe)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jan 11, 2023
@kumaraditya303
[3.9] [3.10] pythonGH-100892: Fix race in clearing threading.local (p…
7329213 
…ythonGH-100922).

(cherry picked from commit 762745a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>.
(cherry picked from commit 683e9fe)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
kumaraditya303 added a commit that referenced this pull request Jan 11, 2023
@kumaraditya303
[3.11] GH-100892: Fix race in clearing threading.local (GH-100922). (…
e707671 
…#100937)

(cherry picked from commit 762745a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
kumaraditya303 added a commit that referenced this pull request Jan 11, 2023
@kumaraditya303
[3.10] GH-100892: Fix race in clearing threading.local (GH-100922). (…
a3b6577 
…#100938)

(cherry picked from commit 762745a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
ambv pushed a commit that referenced this pull request Jan 20, 2023
@kumaraditya303
[3.9] GH-100892: Fix race in clearing threading.local (GH-100922) (#…
6954203 
…100939)

[3.9] [3.10] GH-100892: Fix race in clearing `threading.local` (GH-100922).
(cherry picked from commit 762745a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>.
(cherry picked from commit 683e9fe)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@Zac-HD Zac-HD mentioned this pull request Feb 21, 2023
Closed
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull request May 21, 2024
@kumaraditya303 @mgorny
[3.9] pythonGH-100892: Fix race in clearing threading.local (python…
8e41e91 
…GH-100922) (python#100939)

[3.9] [3.10] pythonGH-100892: Fix race in clearing `threading.local` (pythonGH-100922).
(cherry picked from commit 762745a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>.
(cherry picked from commit 683e9fe)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

[adjusted for 3.8 by Michał Górny]
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull request Sep 19, 2024
@kumaraditya303 @mgorny
[3.9] pythonGH-100892: Fix race in clearing threading.local (python…
4742bf1 
…GH-100922) (python#100939)

[3.9] [3.10] pythonGH-100892: Fix race in clearing `threading.local` (pythonGH-100922).
(cherry picked from commit 762745a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>.
(cherry picked from commit 683e9fe)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

[adjusted for 3.8 by Michał Górny]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@ambv ambv Awaiting requested review from ambv

Assignees

@kumaraditya303 kumaraditya303

Labels

type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303 @pablogsal @miss-islington @bedevere-bot