[3.11] GH-99729: Unlink frames before clearing them

[brandtbucher]

This is a manual backport of the not-yet-merged #100030.

That one should happen first, but I thought I'd get this ready while the buildbots ran.

• Issue: Frame teardown can create frame objects #99729

[markshannon]

Looks good.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 5314243 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

[vstinner]

I'm curious about "Refleaks" buildbot timings ("Total duration"):

• AMD64 Fedora Stable Refleaks PR: 46 min 9 sec
• AMD64 RHEL7 Refleaks PR: 39 min
• PPC64LE Fedora Stable Refleaks PR: 36 min 12 sec
• PPC64LE RHEL8 Refleaks PR: 40 min 31 sec
• aarch64 Fedora Stable Refleaks PR: 40 min 42 sec
• aarch64 RHEL8 Refleaks PR: 50 min 24 sec
• s390x Fedora Refleaks PR: 40 min 20 sec
• s390x RHEL7 Refleaks PR: 56 min 46 sec
• s390x RHEL8 Refleaks PR: 36 min 57 sec

On-going: PPC64LE RHEL7 Refleaks PR (26 min).

[brandtbucher]

I'm away from my computer for the next hour or so, so feel free to merge when ready.

[pablogsal]

I'm curious about "Refleaks" buildbot timings ("Total duration"):

• AMD64 Fedora Stable Refleaks PR: 46 min 9 sec
• AMD64 RHEL7 Refleaks PR: 39 min
• PPC64LE Fedora Stable Refleaks PR: 36 min 12 sec
• PPC64LE RHEL8 Refleaks PR: 40 min 31 sec
• aarch64 Fedora Stable Refleaks PR: 40 min 42 sec
• aarch64 RHEL8 Refleaks PR: 50 min 24 sec
• s390x Fedora Refleaks PR: 40 min 20 sec
• s390x RHEL7 Refleaks PR: 56 min 46 sec
• s390x RHEL8 Refleaks PR: 36 min 57 sec

On-going: PPC64LE RHEL7 Refleaks PR (26 min).

What's curious about this?

[vstinner]

What's curious about this?

On Discord, @markshannon wrote that " PPC64LE RHEL7 Refleaks PR" took "forever" :-)

[markshannon]

The problem is not that the individual runs take a long time, but that one overworked machine is running many of them, so collectively they take "forever" (actually a few hours)
https://buildbot.python.org/all/#/workers/6

[vstinner]

https://buildbot.python.org/all/#/workers/6

I looked at the latest 10 builds. They waited between 1 second and 30 minutes, and the slowest took 1 hour (Refleaks build, tests took 50 min).