Use write_png from branca, remove from folium#1708
Merged
Conengmo merged 1 commit intopython-visualization:mainfrom Jan 24, 2023
Merged
Use write_png from branca, remove from folium#1708Conengmo merged 1 commit intopython-visualization:mainfrom
Conengmo merged 1 commit intopython-visualization:mainfrom
Conversation
This was referenced Jan 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some more duplicate code in folium/utilities.py and branca/utilities.py:
image_to_urlandwrite_png. This time addresswrite_png. In a sibling PR we make sure the version in branca is on par with the one in folium: python-visualization/branca#126. Following that remove the code from folium and use the version in branca as the one true version.Related to #1676. Todo for later is to also address
image_to_url.