Skip to content

Remove AppVeyor and Travis-CI#95

Merged
ocefpaf merged 1 commit intopython-visualization:masterfrom
ocefpaf:remove_appveyor_travis
May 3, 2021
Merged

Remove AppVeyor and Travis-CI#95
ocefpaf merged 1 commit intopython-visualization:masterfrom
ocefpaf:remove_appveyor_travis

Conversation

@ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Apr 19, 2021

We need to add some extra tests on GHA before merging this one.

@ocefpaf ocefpaf force-pushed the remove_appveyor_travis branch from fa77f2b to 4dce335 Compare April 19, 2021 20:43
@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 21, 2021

We need to add some extra tests on GHA before merging this one.

I'll have to separate the selenium tests from the rest of the tests b/c they only run on 3.9 for some reason.

@ocefpaf ocefpaf marked this pull request as draft April 21, 2021 13:27
@ocefpaf ocefpaf force-pushed the remove_appveyor_travis branch from 25aa285 to 1e1fe4f Compare April 21, 2021 19:02
@ocefpaf ocefpaf force-pushed the remove_appveyor_travis branch from 0a03f07 to e8a8e37 Compare April 21, 2021 19:55
@ocefpaf ocefpaf marked this pull request as ready for review April 21, 2021 19:55
@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 21, 2021

@Conengmo this is ready for review now. The only missing pieces are the coding standards and documentation. I'm working on docs for both folium and branca and coding standards won't be needed if we adopt pre-commit hooks.

@Conengmo Conengmo self-requested a review April 21, 2021 20:13
@ocefpaf ocefpaf merged commit a872bef into python-visualization:master May 3, 2021
@ocefpaf ocefpaf deleted the remove_appveyor_travis branch May 3, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants