Add message to trust notebook#75
Merged
Conengmo merged 2 commits intopython-visualization:masterfrom Apr 27, 2020
Merged
Conversation
ocefpaf
approved these changes
Apr 27, 2020
Member
ocefpaf
left a comment
ocefpaf
left a comment
There was a problem hiding this comment.
I'll take a look at the Travis-CI failure later. But that may take a while...
Member
Author
|
Thanks for the review! Travis failing is just because a line is too long, I'll fix that. |
|
😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close python-visualization/folium#1277
For Jupyter Notebooks we no longer store the data in the
srcattribute, but load it with Javascript on page load (see #66). This works fine, but requires Javascript to be enabled. Jupyter doesn't run Javascript on notebooks the user didn't run themselves or didn't trust explicitly. This means maps won't show if you open a notebook you got from the internet.If a user executes a cell the map will show. A user can also trust the notebook, which will load the map.
This PR adds a message underneath the map that prompts the user to trust the notebook. If the map loads it will be placed on top of the message.
Notebook is not trusted, map doesn't load, message shows:
Notebook is trusted, map loads:
