fix(cli): make config relocation instructions more explicit#7140
Merged
Secrus merged 7 commits intoJan 22, 2023
Merged
Conversation
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Secrus
requested changes
Dec 20, 2022
Co-authored-by: Bartosz Sokorski <b.sokorski@gmail.com>
Contributor
Author
|
Thank you, @Secrus, for the feedback! |
Member
|
@cpate4 could you please resolve the conflict? |
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Secrus
approved these changes
Jan 22, 2023
Contributor
Author
|
@Secrus - Thank you! This is my first (ever) open source contribution. 🙂 |
cpate4
deleted the
GH-6864_make-config-file-instructions-more-explicit
branch
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6864
Pull Request Check List
Resolves: #6864
With regard to the boxes below, I am not sure if there are tests to write for this as the fix is pertains to "copy" for the deprecation message (as opposed to logic). Happy to update any documentation the team feels is relevant.