Skip to content

Revert "Update packaging requirement to support 21.0"#4748

Merged
abn merged 1 commit into
masterfrom
revert-4362-patch-1
Nov 13, 2021
Merged

Revert "Update packaging requirement to support 21.0"#4748
abn merged 1 commit into
masterfrom
revert-4362-patch-1

Conversation

@neersighted

@neersighted neersighted commented Nov 13, 2021

Copy link
Copy Markdown
Member

Reverts #4362

Versions < 21.0 are currently incompatible with Poetry master thanks to this change: pypa/packaging@d650cfd

Because the tags.py file is no longer totally standalone, the current approach of feeding the file to a Python interpreter's stdin is broken. This needs to be rolled back until we can come up with a new technique for gathering tags.

Additionally, Python 2.7 support is dropped from tags.py which will break management with poetry env. More work is needed to support newer packaging versions.

@neersighted neersighted requested a review from a team November 13, 2021 17:10
@neersighted neersighted added Dependency status/external-issue Issue is caused by external project (platform, dep, etc) labels Nov 13, 2021
@abn abn merged commit 6c83817 into master Nov 13, 2021
@abn abn deleted the revert-4362-patch-1 branch November 13, 2021 17:40
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status/external-issue Issue is caused by external project (platform, dep, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants