add flag --use-env to poetry commands#4179
Conversation
c03e9c7 to
9a6e18d
Compare
0ecffe0 to
efeb695
Compare
7d90e7f to
3d054ca
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
--use-env to env commands--use-env to poetry commands
|
I was about to create a PR with a similar idea that I started coding yesterday, but found this PR when looking for more references now. My idea was to create a new config I even wrote some simple code for that, but as I was testing and reviewing, I noticed that the version check code was only for the But anyway, I think this would be a lot better (for me at least), since I would only need to change the configuration globally once, and poetry would work as needed for all my project when using pyenv. |
Interesting, very similar idea. Just by looking at the code, it seems to be working. I'll see if I can test it sometime soon. I liked how you implemented it without modifying the existing code much, and also how you picked the shell python executable by executing a command instead of using |
|
Closing this in favor of #4852. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The PR adds a new global parameter
--use-env. It adds the ability to tell poetry which python executable it should use in the same waypoetry env usecan do it.The benefits of the parameter are:
envs.tomlI haven't add any tests until now. Recommendations are welcome :)
Pull Request Check List
Resolves: #issue-number-here